diff options
| author | theresalech <theresa@livio.io> | 2018-10-26 09:34:53 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2018-10-26 09:34:53 -0400 |
| commit | 0bd19c8c29c6212fa314003428f6d1c81bc3d528 (patch) | |
| tree | 2cdf9c92d11838cffedf9932d67680f637de6024 | |
| parent | d36316738785c96dab2ee892762ed08c059fffde (diff) | |
| download | sdl_core-fix/issue_2720.tar.gz | |
add best practices link and review informationfix/issue_2720
| -rw-r--r-- | .github/PULL_REQUEST_TEMPLATE.md | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 83c3261f9b..260d3b55ad 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,4 +1,4 @@ -[Things to note: Pull Requests **must** fix an issue. Discussion about the feature / bug takes place in the issue, discussion of the implementation takes place in the PR. Please also see the [Contributing Guide](https://github.com/smartdevicelink/sdl_core/blob/master/.github/CONTRIBUTING.md) for information on branch naming and the CLA. +[Things to note: Pull Requests **must** fix an issue. Discussion about the feature / bug takes place in the issue, discussion of the implementation takes place in the PR. Please also see the [Contributing Guide](https://github.com/smartdevicelink/sdl_core/blob/master/.github/CONTRIBUTING.md) for information on branch naming and the CLA, and the [SmartDeviceLink GitHub Best Practices](https://d83tozu1c8tt6.cloudfront.net/media/resources/SDL_GitHub_BestPractices.pdf) document for more information on how to enter a pull request. Once this PR is ready for review, please request one from @jordynmackool. Delete the above section when you've read it.] @@ -30,4 +30,4 @@ This PR makes **[no / minor / major]** API changes. - [ ] [Task 2] ### CLA -- [ ] I have signed [the CLA](https://docs.google.com/forms/d/e/1FAIpQLSdsgJY33VByaX482zHzi-xUm49JNnmuJOyAM6uegPQ2LXYVfA/viewform)
\ No newline at end of file +- [ ] I have signed [the CLA](https://docs.google.com/forms/d/e/1FAIpQLSdsgJY33VByaX482zHzi-xUm49JNnmuJOyAM6uegPQ2LXYVfA/viewform) |