diff options
| author | Shobhit Adlakha <ShobhitAd@users.noreply.github.com> | 2019-04-29 10:39:04 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2019-04-29 10:39:04 -0400 |
| commit | 6706ce1dee84d8cb7d48bbbee685f9feb35955cd (patch) | |
| tree | 5551329000495979f1781c7ef523f6afd3b9e330 | |
| parent | cedac89de0756fdab6f9cbe2c4a202e9370ca2be (diff) | |
| download | sdl_core-hotfix/on_app_service_data_error_cases.tar.gz | |
Apply suggestions from code reviewhotfix/on_app_service_data_error_cases
Co-Authored-By: jacobkeeler <jacob.keeler@livioradio.com>
2 files changed, 8 insertions, 8 deletions
diff --git a/src/components/application_manager/rpc_plugins/app_service_rpc_plugin/src/commands/hmi/on_as_app_service_data_notification_from_hmi.cc b/src/components/application_manager/rpc_plugins/app_service_rpc_plugin/src/commands/hmi/on_as_app_service_data_notification_from_hmi.cc index 1da213e93d..575aa5ca28 100644 --- a/src/components/application_manager/rpc_plugins/app_service_rpc_plugin/src/commands/hmi/on_as_app_service_data_notification_from_hmi.cc +++ b/src/components/application_manager/rpc_plugins/app_service_rpc_plugin/src/commands/hmi/on_as_app_service_data_notification_from_hmi.cc @@ -63,14 +63,14 @@ void OnASAppServiceDataNotificationFromHMI::Run() { AppService* service = application_manager_.GetAppServiceManager().FindServiceByID(service_id); if (!service) { - LOG4CXX_DEBUG( + LOG4CXX_ERROR( logger_, "No published services exist with service ID: " << service_id); return; } else if (service->mobile_service) { - LOG4CXX_DEBUG(logger_, "Service was not published by the HMI"); + LOG4CXX_ERROR(logger_, "Service was not published by the HMI"); return; } else if (!service->record[strings::service_active].asBool()) { - LOG4CXX_DEBUG(logger_, "Service is not active"); + LOG4CXX_ERROR(logger_, "Service is not active"); return; } @@ -81,7 +81,7 @@ void OnASAppServiceDataNotificationFromHMI::Run() { service->record[strings::service_manifest][strings::service_type] .asString(); if (published_service_type != service_type) { - LOG4CXX_DEBUG(logger_, + LOG4CXX_ERROR(logger_, "Service type mismatch, expected " << service_type << ", but service was published with type " diff --git a/src/components/application_manager/rpc_plugins/app_service_rpc_plugin/src/commands/mobile/on_app_service_data_notification_from_mobile.cc b/src/components/application_manager/rpc_plugins/app_service_rpc_plugin/src/commands/mobile/on_app_service_data_notification_from_mobile.cc index bfd9921e67..2e92bd19bb 100644 --- a/src/components/application_manager/rpc_plugins/app_service_rpc_plugin/src/commands/mobile/on_app_service_data_notification_from_mobile.cc +++ b/src/components/application_manager/rpc_plugins/app_service_rpc_plugin/src/commands/mobile/on_app_service_data_notification_from_mobile.cc @@ -85,15 +85,15 @@ void OnAppServiceDataNotificationFromMobile::Run() { AppService* service = application_manager_.GetAppServiceManager().FindServiceByID(service_id); if (!service) { - LOG4CXX_DEBUG( + LOG4CXX_ERROR( logger_, "No published services exist with service ID: " << service_id); return; } else if (!service->mobile_service || service->connection_key != app_connection_key) { - LOG4CXX_DEBUG(logger_, "Service was not published by this application"); + LOG4CXX_ERROR(logger_, "Service was not published by this application"); return; } else if (!service->record[strings::service_active].asBool()) { - LOG4CXX_DEBUG(logger_, "Service is not active"); + LOG4CXX_ERROR(logger_, "Service is not active"); return; } @@ -101,7 +101,7 @@ void OnAppServiceDataNotificationFromMobile::Run() { service->record[strings::service_manifest][strings::service_type] .asString(); if (published_service_type != service_type) { - LOG4CXX_DEBUG(logger_, + LOG4CXX_ERROR(logger_, "Service type mismatch, expected " << service_type << ", but service was published with type " |