Fix/ccb 3141 change command request inheritance structure (#3591)

* Change command request inheritance structure.
Fix data races during requests event processing.

* Change commands according to new inheritance structure.

* Change unit tests according new inheritance structure.

* Fix review comments

* Fix build after merge

* Fix format style

* Fix recursion in SetGlobalProperties

* Add delay before request releasing

That gives to event dispatcher some time to figure
out that event should not be rasied for a finalized request
and this request will be released soon. Also, this allows
to avoid calling some virtual functions on pointer to
invalidated object.

* Fix data races in EventDispatcher

Now reference counter is increased indirectly
by event dispatcher before calling `HandleOnEvent()`
of specific observer.
This will guarantee that during `HandleOnEvent` the
command object is still be alive.

* Revert changes for SetGlobalProperties

Co-authored-by: v-seme12 <vsemenyuk@kiev.luxoft.com>
Co-authored-by: Andrii Kalinich <AKalinich@luxoft.com>

1 files changed, 1 insertions, 1 deletions

diff --git a/src/components/application_manager/rpc_plugins/sdl_rpc_plugin/src/commands/hmi/sdl_activate_app_request.cc b/src/components/application_manager/rpc_plugins/sdl_rpc_plugin/src/commands/hmi/sdl_activate_app_request.cc
index 4de8b17b8d..a8b34bf2d4 100644
--- a/src/components/application_manager/rpc_plugins/sdl_rpc_plugin/src/commands/hmi/sdl_activate_app_request.cc
+++ b/src/components/application_manager/rpc_plugins/sdl_rpc_plugin/src/commands/hmi/sdl_activate_app_request.cc
@@ -272,7 +272,7 @@ void SDLActivateAppRequest::Run() {
 }
 
 #endif  // EXTERNAL_PROPRIETARY_MODE
-void SDLActivateAppRequest::onTimeOut() {
+void SDLActivateAppRequest::OnTimeOut() {
   using namespace hmi_apis::FunctionID;
   using namespace hmi_apis::Common_Result;
   using namespace application_manager;