summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--src/components/application_manager/src/application_manager_impl.cc4
-rw-r--r--src/components/connection_handler/include/connection_handler/connection_handler_impl.h3
-rw-r--r--src/components/connection_handler/src/connection_handler_impl.cc1
-rw-r--r--src/components/include/connection_handler/connection_handler.h3
-rw-r--r--src/components/include/test/connection_handler/mock_connection_handler.h5
5 files changed, 6 insertions, 10 deletions
diff --git a/src/components/application_manager/src/application_manager_impl.cc b/src/components/application_manager/src/application_manager_impl.cc
index ef008b7200..3b5c1b2c7c 100644
--- a/src/components/application_manager/src/application_manager_impl.cc
+++ b/src/components/application_manager/src/application_manager_impl.cc
@@ -808,7 +808,7 @@ void ApplicationManagerImpl::CollectCloudAppInformation() {
pending_device_map_.insert(
std::pair<std::string, std::string>(endpoint, *it));
- connection_handler().AddCloudAppDevice(*it, endpoint, cloud_transport_type);
+ connection_handler().AddCloudAppDevice(endpoint, cloud_transport_type);
}
}
@@ -873,7 +873,7 @@ void ApplicationManagerImpl::CreatePendingApplication(
mobile_apis::HybridAppPreference::eType>::
StringToEnum(hybrid_app_preference_str, &hybrid_app_preference_enum);
- if (!convert_result) {
+ if (!hybrid_app_preference_str.empty() && !convert_result) {
LOG4CXX_ERROR(
logger_,
"Could not convert string to enum: " << hybrid_app_preference_str);
diff --git a/src/components/connection_handler/include/connection_handler/connection_handler_impl.h b/src/components/connection_handler/include/connection_handler/connection_handler_impl.h
index 7be94c5f70..899d17995c 100644
--- a/src/components/connection_handler/include/connection_handler/connection_handler_impl.h
+++ b/src/components/connection_handler/include/connection_handler/connection_handler_impl.h
@@ -120,8 +120,7 @@ class ConnectionHandlerImpl
void ConnectToAllDevices() OVERRIDE;
- void AddCloudAppDevice(const std::string& policy_app_id,
- const std::string& endpoint,
+ void AddCloudAppDevice(const std::string& endpoint,
const std::string& cloud_transport_type) OVERRIDE;
void StartTransportManager() OVERRIDE;
diff --git a/src/components/connection_handler/src/connection_handler_impl.cc b/src/components/connection_handler/src/connection_handler_impl.cc
index ed2522593c..9060350c9b 100644
--- a/src/components/connection_handler/src/connection_handler_impl.cc
+++ b/src/components/connection_handler/src/connection_handler_impl.cc
@@ -1315,7 +1315,6 @@ void ConnectionHandlerImpl::ConnectToAllDevices() {
}
void ConnectionHandlerImpl::AddCloudAppDevice(
- const std::string& policy_app_id,
const std::string& endpoint,
const std::string& cloud_transport_type) {
transport_manager_.AddCloudDevice(endpoint, cloud_transport_type);
diff --git a/src/components/include/connection_handler/connection_handler.h b/src/components/include/connection_handler/connection_handler.h
index 93939fc782..9ca9a8d144 100644
--- a/src/components/include/connection_handler/connection_handler.h
+++ b/src/components/include/connection_handler/connection_handler.h
@@ -93,8 +93,7 @@ class ConnectionHandler {
virtual void ConnectToAllDevices() = 0;
- virtual void AddCloudAppDevice(const std::string& policy_app_id,
- const std::string& endpoint,
+ virtual void AddCloudAppDevice(const std::string& endpoint,
const std::string& cloud_transport_type) = 0;
/**
diff --git a/src/components/include/test/connection_handler/mock_connection_handler.h b/src/components/include/test/connection_handler/mock_connection_handler.h
index bdc0469844..cde835759f 100644
--- a/src/components/include/test/connection_handler/mock_connection_handler.h
+++ b/src/components/include/test/connection_handler/mock_connection_handler.h
@@ -63,9 +63,8 @@ class MockConnectionHandler : public connection_handler::ConnectionHandler {
MOCK_CONST_METHOD2(RunAppOnDevice,
void(const std::string&, const std::string&));
MOCK_METHOD0(ConnectToAllDevices, void());
- MOCK_METHOD3(AddCloudAppDevice,
- void(const std::string& policy_app_id,
- const std::string& endpoint,
+ MOCK_METHOD2(AddCloudAppDevice,
+ void(const std::string& endpoint,
const std::string& cloud_transport_type));
MOCK_METHOD1(CloseRevokedConnection, void(uint32_t connection_key));
MOCK_METHOD1(CloseConnection, void(ConnectionHandle connection_handle));