diff options
Diffstat (limited to 'src/components/protocol_handler')
3 files changed, 7 insertions, 4 deletions
diff --git a/src/components/protocol_handler/src/incoming_data_handler.cc b/src/components/protocol_handler/src/incoming_data_handler.cc index f0692b3304..08997acaac 100644 --- a/src/components/protocol_handler/src/incoming_data_handler.cc +++ b/src/components/protocol_handler/src/incoming_data_handler.cc @@ -158,7 +158,7 @@ RESULT_CODE IncomingDataHandler::CreateFrame( } SDL_LOG_DEBUG("Payload size " << header_.dataSize); const uint32_t packet_size = GetPacketSize(header_); - if (packet_size <= 0) { + if (packet_size == 0) { SDL_LOG_WARN("Null packet size"); ++data_it; --data_size; diff --git a/src/components/protocol_handler/src/protocol_handler_impl.cc b/src/components/protocol_handler/src/protocol_handler_impl.cc index f1179e7107..dc710549cd 100644 --- a/src/components/protocol_handler/src/protocol_handler_impl.cc +++ b/src/components/protocol_handler/src/protocol_handler_impl.cc @@ -1243,7 +1243,7 @@ void ProtocolHandlerImpl::OnTransportConfigUpdated( if (st.secondary_transport != kDisabledSecondary) { SendTransportUpdateEvent(st.primary_transport, itr->first); } - itr++; + ++itr; } } @@ -2573,7 +2573,7 @@ void ProtocolHandlerImpl::GenerateSecondaryTransportsForStartSessionAck( secondaryTransports.push_back("TCP_WIFI"); } - it++; + ++it; } } @@ -2600,7 +2600,7 @@ void ProtocolHandlerImpl::GenerateServiceTransportsForStartSessionAck( bool fPrimaryAdded = false; bool fSecondaryAdded = false; std::vector<std::string>::const_iterator it = service_transports.begin(); - for (; it != service_transports.end(); it++) { + for (; it != service_transports.end(); ++it) { const utils::custom_string::CustomString transport(*it); SDL_LOG_TRACE( diff --git a/src/components/protocol_handler/src/protocol_payload.cc b/src/components/protocol_handler/src/protocol_payload.cc index 8916fe91b0..a18f04f8a1 100644 --- a/src/components/protocol_handler/src/protocol_payload.cc +++ b/src/components/protocol_handler/src/protocol_payload.cc @@ -93,8 +93,11 @@ std::ostream& operator<<(std::ostream& os, const ProtocolPayloadV2& payload) { << ", data (bytes): " << payload.data.size() << ")"; } +#ifdef BUILD_TESTS +// cppcheck-suppress unusedFunction //Used in unit tests size_t ProtocolPayloadV2SizeBits() { return PayloadHeaderBits; } +#endif // BUILD_TESTS } // namespace protocol_handler |