diff options
author | Justin Beharry <109764059+jshivabeharry@users.noreply.github.com> | 2022-09-01 12:41:45 -0400 |
---|---|---|
committer | GitHub <noreply@github.com> | 2022-09-01 12:41:45 -0400 |
commit | 95da8e724d1d8599a30586539e5eca08b37f5be8 (patch) | |
tree | fae12274cfff90d889e41f4b7bbcf03e453081c6 | |
parent | 899bcbfca63e755c8806b781a31df87c6fd436b9 (diff) | |
download | sdl_ios-95da8e724d1d8599a30586539e5eca08b37f5be8.tar.gz |
Apply suggestions from code review
Co-authored-by: Joel Fischer <joeljfischer@gmail.com>
3 files changed, 13 insertions, 13 deletions
diff --git a/SmartDeviceLinkTests/ProtocolSpecs/HeaderSpecs/SDLProtocolHeaderSpec.m b/SmartDeviceLinkTests/ProtocolSpecs/HeaderSpecs/SDLProtocolHeaderSpec.m index 9fcff743c..0e042ba4b 100644 --- a/SmartDeviceLinkTests/ProtocolSpecs/HeaderSpecs/SDLProtocolHeaderSpec.m +++ b/SmartDeviceLinkTests/ProtocolSpecs/HeaderSpecs/SDLProtocolHeaderSpec.m @@ -38,15 +38,15 @@ describe(@"DetermineVersion Tests", ^ { }); }); -describe(@"Hash Tests", ^ { - it(@"Should return equivalent hash values", ^ { +describe(@"hashing tests", ^ { + it(@"should return equivalent hash values", ^ { SDLProtocolHeader *testHeader = [[SDLProtocolHeader alloc] init]; SDLProtocolHeader *equalHeader = [[SDLProtocolHeader alloc] init]; expect([testHeader hash]).to(equal([equalHeader hash])); }); - it(@"Should return unequivalent hash values", ^ { + it(@"should return unequivalent hash values", ^ { SDLProtocolHeader *testHeader = [[SDLProtocolHeader alloc] init]; SDLProtocolHeader *unequalHeader = [[SDLProtocolHeader alloc] init]; unequalHeader.frameType = SDLFrameTypeFirst; diff --git a/SmartDeviceLinkTests/ProtocolSpecs/HeaderSpecs/SDLV1ProtocolHeaderSpec.m b/SmartDeviceLinkTests/ProtocolSpecs/HeaderSpecs/SDLV1ProtocolHeaderSpec.m index d5ddb4707..f2218f7db 100644 --- a/SmartDeviceLinkTests/ProtocolSpecs/HeaderSpecs/SDLV1ProtocolHeaderSpec.m +++ b/SmartDeviceLinkTests/ProtocolSpecs/HeaderSpecs/SDLV1ProtocolHeaderSpec.m @@ -86,20 +86,20 @@ describe(@"RPCPayloadWithData Test", ^ { }); }); -describe(@"IsEqual Tests", ^ { - it (@"Should be equal to copy of header", ^ { +describe(@"equality tests", ^ { + it (@"should be equal to copy of header", ^ { // Create exact copy of test header SDLV1ProtocolHeader *equalHeader = [testHeader copy]; - expect([testHeader isEqual:equalHeader]).to(equal(@YES)); + expect([testHeader isEqual:equalHeader]).to(beTrue()); }); - it (@"Should not be equal to a different header", ^ { + it (@"should not be equal to a different header", ^ { // create a slighty different version of test header SDLV1ProtocolHeader *unequalHeader = [testHeader copy]; unequalHeader.encrypted = NO; - expect(([testHeader isEqual:unequalHeader])).to(equal(@NO)); + expect(([testHeader isEqual:unequalHeader])).to(beFalse()); }); }); diff --git a/SmartDeviceLinkTests/ProtocolSpecs/HeaderSpecs/SDLV2ProtocolHeaderSpec.m b/SmartDeviceLinkTests/ProtocolSpecs/HeaderSpecs/SDLV2ProtocolHeaderSpec.m index 8c1de8a56..ec06d2b4d 100644 --- a/SmartDeviceLinkTests/ProtocolSpecs/HeaderSpecs/SDLV2ProtocolHeaderSpec.m +++ b/SmartDeviceLinkTests/ProtocolSpecs/HeaderSpecs/SDLV2ProtocolHeaderSpec.m @@ -90,20 +90,20 @@ describe(@"RPCPayloadWithData Test", ^ { }); }); -describe(@"IsEqual Tests", ^ { - it (@"Should be equal to copy of header", ^ { +describe(@"equality tests", ^ { + it (@"should be equal to copy of header", ^ { // Create exact copy of test header SDLV2ProtocolHeader *equalHeader = [testHeader copy]; - expect([testHeader isEqual:equalHeader]).to(equal(@YES)); + expect([testHeader isEqual:equalHeader]).to(beTrue()); }); - it (@"Should not be equal to a different header", ^ { + it (@"should not be equal to a different header", ^ { // Create a slighty different version of test header SDLV2ProtocolHeader *unequalHeader = [testHeader copy]; unequalHeader.messageID = 0x6DAB424E; - expect(([testHeader isEqual:unequalHeader])).to(equal(@NO)); + expect(([testHeader isEqual:unequalHeader])).to(beFalse()); }); }); |