BookmarkModel::insert uses a more low level approach to data insertion.

It now uses a SQL query instead of a QSqlRecord. The reason for
using the former is that insertion through QSqlRecord increases the
row count, and emits a signal advertising it, before the row is
commited to the database. This inconsistent state is causing trouble
with the pin/unpin button in the mobile UI.

Reviewed-by: Rafael Brandão

1 files changed, 12 insertions, 7 deletions

diff --git a/src/core/BookmarkModel.cpp b/src/core/BookmarkModel.cpp
index 9726902..cef0c36 100644
--- a/src/core/BookmarkModel.cpp
+++ b/src/core/BookmarkModel.cpp
@@ -55,14 +55,19 @@ bool BookmarkModel::select()
 
 void BookmarkModel::insert(const QString& name, const QString& url)
 {
-    if (contains(url))
+    if (url.isEmpty() || contains(url))
         return;
-    QSqlRecord record = this->record();
-    record.setValue(QLatin1String("name"), name);
-    record.setValue(QLatin1String("url"), url);
-    record.setValue(QLatin1String("dateAdded"), QDateTime::currentDateTime().toTime_t());
-
-    insertRecord(-1, record);
+    QModelIndex index = QModelIndex();
+    beginInsertRows(index, rowCount(index), rowCount(index));
+    QSqlQuery sqlQuery(database());
+    static QString insertStatement = QLatin1String("INSERT INTO bookmarks (name, url, dateAdded) VALUES (?, ?, ?)");
+    sqlQuery.prepare(insertStatement);
+    sqlQuery.addBindValue(name);
+    sqlQuery.addBindValue(url);
+    sqlQuery.addBindValue(QDateTime::currentDateTime().toTime_t());
+    sqlQuery.exec();
+    select();
+    endInsertRows();
     submitAll();
 }