plug leak (append_string_to_list): don't strdup() @append.

2 files changed, 12 insertions, 4 deletions

diff --git a/ChangeLog b/ChangeLog
index f885983..91573e9 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2005-02-26  Vincent Untz  <vincent@vuntz.net>
+
+	* libsn/sn-xmessages.c: (parse_property): plug leak
+	(append_string_to_list): don't strdup() @append.
+
 2004-11-10  Mark McLoughlin  <mark@skynet.ie>
 
 	* configure.in: post-release bump to 0.9.
diff --git a/libsn/sn-xmessages.c b/libsn/sn-xmessages.c
index 44327f2..da7a8f4 100644
--- a/libsn/sn-xmessages.c
+++ b/libsn/sn-xmessages.c
@@ -534,14 +534,16 @@ sn_internal_serialize_message (const char   *prefix,
   return retval;
 }
 
+/* Takes ownership of @append
+ */
 static void
-append_string_to_list (char     ***list,
-                       const char *append)
+append_string_to_list (char ***list,
+                       char   *append)
 {
   if (*list == NULL)
     {
       *list = sn_new0 (char*, 2);
-      (*list)[0] = sn_internal_strdup (append);
+      (*list)[0] = append;
     }
   else
     {
@@ -552,7 +554,7 @@ append_string_to_list (char     ***list,
         ++i;
 
       *list = sn_renew (char*, *list, i + 2);
-      (*list)[i] = sn_internal_strdup (append);
+      (*list)[i] = append;
       (*list)[i+1] = NULL;
     }
 }
@@ -691,6 +693,7 @@ parse_property (const char  *str,
     if (!unescape_string_inplace (p, &end))
       {
         sn_free (copy);
+        sn_free (name);
         return FALSE;
       }