summaryrefslogtreecommitdiff
path: root/logsrvd/logsrvd.c
diff options
context:
space:
mode:
authorTodd C. Miller <Todd.Miller@sudo.ws>2021-04-23 17:02:35 -0600
committerTodd C. Miller <Todd.Miller@sudo.ws>2021-04-23 17:02:35 -0600
commit100b584588cc3c416583b794f7d643979768225e (patch)
tree694f7ec8cb2d7b6aea45338731e86cc007b4dca0 /logsrvd/logsrvd.c
parent10ae486e90423d8b1de6f7c463ca4c42fd4576f7 (diff)
downloadsudo-100b584588cc3c416583b794f7d643979768225e.tar.gz
In connection_closure_free() only close sock if it is not -1.
When relaying from a journal there will be no socket. Coverity CID 221403
Diffstat (limited to 'logsrvd/logsrvd.c')
-rw-r--r--logsrvd/logsrvd.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/logsrvd/logsrvd.c b/logsrvd/logsrvd.c
index ec64c23c4..55373d925 100644
--- a/logsrvd/logsrvd.c
+++ b/logsrvd/logsrvd.c
@@ -113,7 +113,8 @@ connection_closure_free(struct connection_closure *closure)
TAILQ_REMOVE(&connections, closure, entries);
if (closure->relay_closure != NULL)
relay_closure_free(closure->relay_closure);
- close(closure->sock);
+ if (closure->sock != -1)
+ close(closure->sock);
iolog_close_all(closure);
sudo_ev_free(closure->commit_ev);
sudo_ev_free(closure->read_ev);