Set umask to be less restrictive before creating parent directories.

Otherwise we could end up creating them with a more restrictive
mode than indended.  Coverity CID 221592

1 files changed, 6 insertions, 0 deletions

diff --git a/logsrvd/logsrvd.c b/logsrvd/logsrvd.c
index 20929af00..19d8b3152 100644
--- a/logsrvd/logsrvd.c
+++ b/logsrvd/logsrvd.c
@@ -1751,12 +1751,16 @@ write_pidfile(void)
     FILE *fp;
     int fd;
     bool success;
+    mode_t oldmask;
     char *pid_file = (char *)logsrvd_conf_pid_file();
     debug_decl(write_pidfile, SUDO_DEBUG_UTIL);
 
     if (pid_file == NULL)
 	debug_return;
 
+    /* Default logsrvd umask is more restrictive (077). */
+    oldmask = umask(S_IWGRP|S_IWOTH);
+
     /* sudo_mkdir_parents() modifies the path but restores it before return. */
     success = sudo_mkdir_parents(pid_file, ROOT_UID, ROOT_GID,
 	S_IRWXU|S_IXGRP|S_IXOTH, false);
@@ -1774,6 +1778,8 @@ write_pidfile(void)
 	    fclose(fp);
 	}
     }
+    umask(oldmask);
+
     debug_return;
 }