diff options
| author | Roshan Shariff <roshan.shariff@gmail.com> | 2021-05-24 01:30:38 -0600 |
|---|---|---|
| committer | Luca Boccassi <luca.boccassi@gmail.com> | 2021-05-24 18:40:01 +0100 |
| commit | 07c0e5eeaf3183963f4d680555d2289a33735d6e (patch) | |
| tree | d4eef8bde38cf34339f15e1d22acb41f47e8d0c0 | |
| parent | f0c7e594ed61504a540df00e597ea30424c2d0ed (diff) | |
| download | systemd-07c0e5eeaf3183963f4d680555d2289a33735d6e.tar.gz | |
rules.d: Properly quote $env{MODALIAS}
Add quotes around use of $env{MODALIAS} in rules.d/80-drivers.rules. The
modalias can contain whitespace, for example when it is dynamically generated
using device or vendor IDs.
| -rw-r--r-- | rules.d/80-drivers.rules | 2 | ||||
| -rw-r--r-- | test/fuzz/fuzz-udev-rules/80-drivers.rules | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/rules.d/80-drivers.rules b/rules.d/80-drivers.rules index 16fa5d8e32..57d69b8232 100644 --- a/rules.d/80-drivers.rules +++ b/rules.d/80-drivers.rules @@ -2,7 +2,7 @@ ACTION!="add", GOTO="drivers_end" -ENV{MODALIAS}=="?*", RUN{builtin}+="kmod load $env{MODALIAS}" +ENV{MODALIAS}=="?*", RUN{builtin}+="kmod load '$env{MODALIAS}'" SUBSYSTEM=="tifm", ENV{TIFM_CARD_TYPE}=="SD", RUN{builtin}+="kmod load tifm_sd" SUBSYSTEM=="tifm", ENV{TIFM_CARD_TYPE}=="MS", RUN{builtin}+="kmod load tifm_ms" SUBSYSTEM=="memstick", RUN{builtin}+="kmod load ms_block mspro_block" diff --git a/test/fuzz/fuzz-udev-rules/80-drivers.rules b/test/fuzz/fuzz-udev-rules/80-drivers.rules index 16fa5d8e32..57d69b8232 100644 --- a/test/fuzz/fuzz-udev-rules/80-drivers.rules +++ b/test/fuzz/fuzz-udev-rules/80-drivers.rules @@ -2,7 +2,7 @@ ACTION!="add", GOTO="drivers_end" -ENV{MODALIAS}=="?*", RUN{builtin}+="kmod load $env{MODALIAS}" +ENV{MODALIAS}=="?*", RUN{builtin}+="kmod load '$env{MODALIAS}'" SUBSYSTEM=="tifm", ENV{TIFM_CARD_TYPE}=="SD", RUN{builtin}+="kmod load tifm_sd" SUBSYSTEM=="tifm", ENV{TIFM_CARD_TYPE}=="MS", RUN{builtin}+="kmod load tifm_ms" SUBSYSTEM=="memstick", RUN{builtin}+="kmod load ms_block mspro_block" |