diff options
| author | Lennart Poettering <lennart@poettering.net> | 2017-12-23 08:47:55 +0100 |
|---|---|---|
| committer | Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl> | 2017-12-23 08:47:55 +0100 |
| commit | 7e985c69832b261a60fc00cc84d7a47a31fcb008 (patch) | |
| tree | e910c12d2c75a5b6540c8aeb45bd87a8a739a9e0 | |
| parent | 5526ac50fe3f87450786b8d0fcc9d93bb9a75940 (diff) | |
| download | systemd-7e985c69832b261a60fc00cc84d7a47a31fcb008.tar.gz | |
coccinelle: beef up isempty() checks (#7729)
With these additions, coccinelle finds everything fixed by the first
commit in PR #7695. In order not to needlessly conflict with that PR
this PR won't include those fixes, but only the coccinelle changes to
detect them automatically in the future.
| -rw-r--r-- | coccinelle/isempty.cocci | 45 |
1 files changed, 45 insertions, 0 deletions
diff --git a/coccinelle/isempty.cocci b/coccinelle/isempty.cocci index 1374ee40d7..d8d5275889 100644 --- a/coccinelle/isempty.cocci +++ b/coccinelle/isempty.cocci @@ -6,10 +6,55 @@ expression s; @@ expression s; @@ +- strv_length(s) <= 0 ++ strv_isempty(s) +@@ +expression s; +@@ +- strv_length(s) > 0 ++ !strv_isempty(s) +@@ +expression s; +@@ +- strv_length(s) != 0 ++ !strv_isempty(s) +@@ +expression s; +@@ - strlen(s) == 0 + isempty(s) @@ expression s; @@ +- strlen(s) <= 0 ++ isempty(s) +@@ +expression s; +@@ +- strlen(s) > 0 ++ !isempty(s) +@@ +expression s; +@@ +- strlen(s) != 0 ++ !isempty(s) +@@ +expression s; +@@ - strlen_ptr(s) == 0 + isempty(s) +@@ +expression s; +@@ +- strlen_ptr(s) <= 0 ++ isempty(s) +@@ +expression s; +@@ +- strlen_ptr(s) > 0 ++ !isempty(s) +@@ +expression s; +@@ +- strlen_ptr(s) != 0 ++ !isempty(s) |