summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorZbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>2021-04-14 17:10:36 +0200
committerZbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>2021-04-14 17:10:36 +0200
commita2eb2267e44580446ecad37e7206e729cfd78155 (patch)
tree6ea567fa06f1fd261c9e06def84207ba2cab2efb
parenta626cb15c0a029270779887dc3bc12e2dcadd273 (diff)
downloadsystemd-a2eb2267e44580446ecad37e7206e729cfd78155.tar.gz
shared/module-util: fix errno value passed to log function
If r == 0, no harm done. But if r > 0, this would be interpreted as an errno value, wrongly.
-rw-r--r--src/shared/module-util.c9
1 files changed, 4 insertions, 5 deletions
diff --git a/src/shared/module-util.c b/src/shared/module-util.c
index 587e6369fb..1526f59b0a 100644
--- a/src/shared/module-util.c
+++ b/src/shared/module-util.c
@@ -20,11 +20,10 @@ int module_load_and_warn(struct kmod_ctx *ctx, const char *module, bool verbose)
return log_full_errno(verbose ? LOG_ERR : LOG_DEBUG, r,
"Failed to look up module alias '%s': %m", module);
- if (!modlist) {
- log_full_errno(verbose ? LOG_ERR : LOG_DEBUG, r,
- "Failed to find module '%s'", module);
- return -ENOENT;
- }
+ if (!modlist)
+ return log_full_errno(verbose ? LOG_ERR : LOG_DEBUG,
+ SYNTHETIC_ERRNO(ENOENT),
+ "Failed to find module '%s'", module);
kmod_list_foreach(itr, modlist) {
_cleanup_(kmod_module_unrefp) struct kmod_module *mod = NULL;