summaryrefslogtreecommitdiff
path: root/coccinelle
diff options
context:
space:
mode:
authorFrantisek Sumsal <frantisek@sumsal.cz>2019-04-28 20:43:00 +0200
committerFrantisek Sumsal <frantisek@sumsal.cz>2019-04-29 15:38:53 +0200
commit4a4eaade6072d5358f9b8cc7e1a6fca22e7d15e6 (patch)
tree9bf8f70d79e1a366f05d8abd365d6e97805adc51 /coccinelle
parent60d9959dd8ba90e4a112e6e65429b112334d1bf8 (diff)
downloadsystemd-4a4eaade6072d5358f9b8cc7e1a6fca22e7d15e6.tar.gz
coccinelle: exclude certain paths from the transformations
There's no point in running these transformation for certain files, mainly anything from src/boot/efi and src/shared/linux, as this code doesn't have access to our internal utility functions
Diffstat (limited to 'coccinelle')
-rwxr-xr-xcoccinelle/run-coccinelle.sh19
1 files changed, 17 insertions, 2 deletions
diff --git a/coccinelle/run-coccinelle.sh b/coccinelle/run-coccinelle.sh
index 4d882112e6..be80a76a5f 100755
--- a/coccinelle/run-coccinelle.sh
+++ b/coccinelle/run-coccinelle.sh
@@ -1,10 +1,25 @@
#!/bin/bash -e
+# Exclude following paths from the Coccinelle transformations
+EXCLUDED_PATHS=(
+ "src/boot/efi/*"
+ "src/shared/linux/*"
+ "src/basic/linux/*"
+ # Symlinked to test-bus-vtable-cc.cc, which causes issues with the IN_SET macro
+ "src/libsystemd/sd-bus/test-bus-vtable.c"
+)
+
top="$(git rev-parse --show-toplevel)"
-files="$(git ls-files ':/*.[ch]')"
iso_defs="$top/coccinelle/systemd-definitions.iso"
args=
+# Create an array from files tracked by git...
+mapfile -t files < <(git ls-files ':/*.[ch]')
+# ...and filter everything that matches patterns from EXCLUDED_PATHS
+for excl in "${EXCLUDED_PATHS[@]}"; do
+ files=(${files[@]//$excl})
+done
+
case "$1" in
-i)
args="$args --in-place"
@@ -22,7 +37,7 @@ for SCRIPT in ${@-$top/coccinelle/*.cocci} ; do
TMPFILE=`mktemp`
echo "+ spatch --sp-file $SCRIPT $args ..."
parallel --halt now,fail=1 --keep-order --noswap --max-args=20 \
- spatch --iso-file $iso_defs --sp-file $SCRIPT $args ::: $files \
+ spatch --iso-file $iso_defs --sp-file $SCRIPT $args ::: "${files[@]}" \
2>"$TMPFILE" || cat "$TMPFILE"
echo -e "--x-- Processed $SCRIPT --x--\n"
done