diff options
| author | Daan De Meyer <daan.j.demeyer@gmail.com> | 2022-12-09 12:10:09 +0100 |
|---|---|---|
| committer | Daan De Meyer <daan.j.demeyer@gmail.com> | 2022-12-09 15:37:43 +0100 |
| commit | 52c602d4c6a744a1000f7bd8cc04a4c3a8a8ca9a (patch) | |
| tree | 52a579614effb0b8fe9f979da1123302e296cdfb /docs/CONTRIBUTING.md | |
| parent | 7aebbdcfa9445d16dc3f765a8ee61a6d7f1daf0f (diff) | |
| download | systemd-52c602d4c6a744a1000f7bd8cc04a4c3a8a8ca9a.tar.gz | |
ci: Labeler improvements
- Mention "/please-review" in the contributing guide
- Remove "needs-rebase" on push
- Don't add "please-review" if a green label is set
- Don't add please-review label to draft PRs
- Add please-review when a PR moves out of draft
Diffstat (limited to 'docs/CONTRIBUTING.md')
| -rw-r--r-- | docs/CONTRIBUTING.md | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/docs/CONTRIBUTING.md b/docs/CONTRIBUTING.md index 1db99ad41a..d980f7764e 100644 --- a/docs/CONTRIBUTING.md +++ b/docs/CONTRIBUTING.md @@ -41,6 +41,9 @@ See [reporting of security vulnerabilities](SECURITY.md). * After you have pushed a new version, add a comment explaining the latest changes. If you are a member of the systemd project on GitHub, remove the `reviewed/needs-rework`/`ci-fails/needs-rework`/`needs-rebase` labels. * If you are copying existing code from another source (eg: a compat header), please make sure the license is compatible with `LGPL-2.1-or-later`. If the license is not `LGPL-2.1-or-later`, please add a note to [`LICENSES/README.md`](https://github.com/systemd/systemd/blob/main/LICENSES/README.md). * If the pull request stalls without review, post a ping in a comment after some time has passed. We are always short on reviewer time, and pull requests which haven't seen any recent activity can be easily forgotten. +* Github will automatically add the please-review label when a pull request is opened or updated. If you need +more information after a review, you can comment `/please-review` on the pull request to have Github add the +please-review to the pull request. ## Reviewing Pull Requests |