diff options
| author | Yu Watanabe <watanabe.yu+github@gmail.com> | 2022-03-16 22:32:23 +0900 |
|---|---|---|
| committer | Yu Watanabe <watanabe.yu+github@gmail.com> | 2022-03-19 08:33:33 +0900 |
| commit | de010b0b2e50cf0b3837ce350b116bc92605f67a (patch) | |
| tree | 226685fbb97461692562035501ebc21a314f718c /src/analyze/analyze-security.c | |
| parent | 80a226b26b5e00a2ef9e85d1321da44cd14d051b (diff) | |
| download | systemd-de010b0b2e50cf0b3837ce350b116bc92605f67a.tar.gz | |
strv: make iterator in STRV_FOREACH() declaread in the loop
This also avoids multiple evaluations in STRV_FOREACH_BACKWARDS()
Diffstat (limited to 'src/analyze/analyze-security.c')
| -rw-r--r-- | src/analyze/analyze-security.c | 7 |
1 files changed, 1 insertions, 6 deletions
diff --git a/src/analyze/analyze-security.c b/src/analyze/analyze-security.c index f1d3ff7480..458b681143 100644 --- a/src/analyze/analyze-security.c +++ b/src/analyze/analyze-security.c @@ -2666,7 +2666,6 @@ static int offline_security_checks(char **filenames, _cleanup_free_ char *var = NULL; int r, k; size_t count = 0; - char **filename; if (strv_isempty(filenames)) return 0; @@ -2789,7 +2788,6 @@ static int analyze_security(sd_bus *bus, _cleanup_(sd_bus_message_unrefp) sd_bus_message *reply = NULL; _cleanup_strv_free_ char **list = NULL; size_t n = 0; - char **i; r = sd_bus_call_method( bus, @@ -2841,9 +2839,7 @@ static int analyze_security(sd_bus *bus, ret = r; } - } else { - char **i; - + } else STRV_FOREACH(i, units) { _cleanup_free_ char *mangled = NULL, *instance = NULL; const char *name; @@ -2875,7 +2871,6 @@ static int analyze_security(sd_bus *bus, if (r < 0 && ret >= 0) ret = r; } - } if (overview_table) { if (!FLAGS_SET(flags, ANALYZE_SECURITY_SHORT)) { |