diff options
| author | Lennart Poettering <lennart@poettering.net> | 2021-10-13 12:38:37 +0200 |
|---|---|---|
| committer | Lennart Poettering <lennart@poettering.net> | 2021-10-14 15:57:52 +0200 |
| commit | 2f82562bad423d1190912a4b209647dfac966db2 (patch) | |
| tree | 766d61a085ee9674d8034351a83f64bcdf5d45bb /src/home/homework-cifs.c | |
| parent | 5222651ecc6f46391e5e0d9cf19793bfe65b0ec8 (diff) | |
| download | systemd-2f82562bad423d1190912a4b209647dfac966db2.tar.gz | |
alloc-util: add strdupa_safe() + strndupa_safe() and use it everywhere
Let's define two helpers strdupa_safe() + strndupa_safe() which do the
same as their non-safe counterparts, except that they abort if called
with allocations larger than ALLOCA_MAX.
This should ensure that all our alloca() based allocations are subject
to this limit.
afaics glibc offers three alloca() based APIs: alloca() itself,
strndupa() + strdupa(). With this we have now replacements for all of
them, that take the limit into account.
Diffstat (limited to 'src/home/homework-cifs.c')
| -rw-r--r-- | src/home/homework-cifs.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/home/homework-cifs.c b/src/home/homework-cifs.c index 04a4db8a94..f1dfde50d0 100644 --- a/src/home/homework-cifs.c +++ b/src/home/homework-cifs.c @@ -115,7 +115,7 @@ int home_activate_cifs( return log_error_errno(SYNTHETIC_ERRNO(EINVAL), "User record lacks CIFS service, refusing."); assert_se(hdo = user_record_home_directory(h)); - hd = strdupa(hdo); /* copy the string out, since it might change later in the home record object */ + hd = strdupa_safe(hdo); /* copy the string out, since it might change later in the home record object */ r = home_prepare_cifs(h, false, &setup); if (r < 0) |