diff options
author | Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl> | 2022-08-24 10:41:30 +0200 |
---|---|---|
committer | Yu Watanabe <watanabe.yu+github@gmail.com> | 2022-08-26 11:15:44 +0900 |
commit | 4ccde410a3fc141c9ddf285f24a22dfea99e0287 (patch) | |
tree | 7cf167007dca0a7b1f77e9be3909f11e9b9a9ded /src/machine | |
parent | 2f968def113e601baf8a7dc65263f2f12bc4dc16 (diff) | |
download | systemd-4ccde410a3fc141c9ddf285f24a22dfea99e0287.tar.gz |
tree-wide: change --kill-who to --kill-whom
getopt allows non-ambiguous abbreviations, so backwards-compat is maintained, and
people can use --kill-who (or even shorter abbreviations). English is flexible,
so in common speach people would use both forms, even if "whom" is technically
more correct. The advantage of using the longer form in the code is that we
effectively allow both forms, so we stop punishing people who DTGCT¹, but still
allow people to use the spoken form if they prefer.
1. Do the gramatically correct thing
Diffstat (limited to 'src/machine')
-rw-r--r-- | src/machine/machinectl.c | 22 |
1 files changed, 11 insertions, 11 deletions
diff --git a/src/machine/machinectl.c b/src/machine/machinectl.c index ef600e8ee4..921af58c94 100644 --- a/src/machine/machinectl.c +++ b/src/machine/machinectl.c @@ -68,7 +68,7 @@ static BusPrintPropertyFlags arg_print_flags = 0; static bool arg_full = false; static PagerFlags arg_pager_flags = 0; static bool arg_legend = true; -static const char *arg_kill_who = NULL; +static const char *arg_kill_whom = NULL; static int arg_signal = SIGTERM; static BusTransport arg_transport = BUS_TRANSPORT_LOCAL; static const char *arg_host = NULL; @@ -1044,8 +1044,8 @@ static int kill_machine(int argc, char *argv[], void *userdata) { polkit_agent_open_if_enabled(arg_transport, arg_ask_password); - if (!arg_kill_who) - arg_kill_who = "all"; + if (!arg_kill_whom) + arg_kill_whom = "all"; for (int i = 1; i < argc; i++) { r = bus_call_method( @@ -1054,7 +1054,7 @@ static int kill_machine(int argc, char *argv[], void *userdata) { "KillMachine", &error, NULL, - "ssi", argv[i], arg_kill_who, arg_signal); + "ssi", argv[i], arg_kill_whom, arg_signal); if (r < 0) return log_error_errno(r, "Could not kill machine: %s", bus_error_message(&error, r)); } @@ -1063,14 +1063,14 @@ static int kill_machine(int argc, char *argv[], void *userdata) { } static int reboot_machine(int argc, char *argv[], void *userdata) { - arg_kill_who = "leader"; + arg_kill_whom = "leader"; arg_signal = SIGINT; /* sysvinit + systemd */ return kill_machine(argc, argv, userdata); } static int poweroff_machine(int argc, char *argv[], void *userdata) { - arg_kill_who = "leader"; + arg_kill_whom = "leader"; arg_signal = SIGRTMIN+4; /* only systemd */ return kill_machine(argc, argv, userdata); @@ -2500,7 +2500,7 @@ static int help(int argc, char *argv[], void *userdata) { " -a --all Show all properties, including empty ones\n" " --value When showing properties, only print the value\n" " -l --full Do not ellipsize output\n" - " --kill-who=WHO Who to send signal to\n" + " --kill-whom=WHOM Whom to send signal to\n" " -s --signal=SIGNAL Which signal to send\n" " --uid=USER Specify user ID to invoke shell as\n" " -E --setenv=VAR[=VALUE] Add an environment variable for shell\n" @@ -2534,7 +2534,7 @@ static int parse_argv(int argc, char *argv[]) { ARG_NO_PAGER, ARG_NO_LEGEND, ARG_VALUE, - ARG_KILL_WHO, + ARG_KILL_WHOM, ARG_READ_ONLY, ARG_MKDIR, ARG_NO_ASK_PASSWORD, @@ -2554,7 +2554,7 @@ static int parse_argv(int argc, char *argv[]) { { "full", no_argument, NULL, 'l' }, { "no-pager", no_argument, NULL, ARG_NO_PAGER }, { "no-legend", no_argument, NULL, ARG_NO_LEGEND }, - { "kill-who", required_argument, NULL, ARG_KILL_WHO }, + { "kill-whom", required_argument, NULL, ARG_KILL_WHOM }, { "signal", required_argument, NULL, 's' }, { "host", required_argument, NULL, 'H' }, { "machine", required_argument, NULL, 'M' }, @@ -2693,8 +2693,8 @@ static int parse_argv(int argc, char *argv[]) { arg_legend = false; break; - case ARG_KILL_WHO: - arg_kill_who = optarg; + case ARG_KILL_WHOM: + arg_kill_whom = optarg; break; case 's': |