diff options
author | Yu Watanabe <watanabe.yu+github@gmail.com> | 2022-12-20 10:02:10 +0900 |
---|---|---|
committer | GitHub <noreply@github.com> | 2022-12-20 10:02:10 +0900 |
commit | 57e7af551edafa8ad840a26c28184bc6339e09ad (patch) | |
tree | 083f7070d545fac20aa2375426d9d0c3ac9fe1ac /src/machine | |
parent | 8d8d4b092aa94803c01638a2a7343d12f2b2776c (diff) | |
parent | 351293b3bbea3623aa9f643272ca5936951e34da (diff) | |
download | systemd-57e7af551edafa8ad840a26c28184bc6339e09ad.tar.gz |
Merge pull request #25786 from keszybz/ebadf
Use -EBADF for fd initialization
Diffstat (limited to 'src/machine')
-rw-r--r-- | src/machine/image-dbus.c | 8 | ||||
-rw-r--r-- | src/machine/machine-dbus.c | 24 | ||||
-rw-r--r-- | src/machine/machinectl.c | 10 | ||||
-rw-r--r-- | src/machine/machined-dbus.c | 12 | ||||
-rw-r--r-- | src/machine/operation.c | 2 |
5 files changed, 28 insertions, 28 deletions
diff --git a/src/machine/image-dbus.c b/src/machine/image-dbus.c index 84dc95eca1..f8c09a8b7c 100644 --- a/src/machine/image-dbus.c +++ b/src/machine/image-dbus.c @@ -31,7 +31,7 @@ int bus_image_method_remove( void *userdata, sd_bus_error *error) { - _cleanup_close_pair_ int errno_pipe_fd[2] = { -1, -1 }; + _cleanup_close_pair_ int errno_pipe_fd[2] = { -EBADF, -EBADF }; Image *image = ASSERT_PTR(userdata); Manager *m = image->userdata; pid_t child; @@ -88,7 +88,7 @@ int bus_image_method_remove( return r; } - errno_pipe_fd[0] = -1; + errno_pipe_fd[0] = -EBADF; return 1; } @@ -145,7 +145,7 @@ int bus_image_method_clone( void *userdata, sd_bus_error *error) { - _cleanup_close_pair_ int errno_pipe_fd[2] = { -1, -1 }; + _cleanup_close_pair_ int errno_pipe_fd[2] = { -EBADF, -EBADF }; Image *image = ASSERT_PTR(userdata); Manager *m = ASSERT_PTR(image->userdata); const char *new_name; @@ -211,7 +211,7 @@ int bus_image_method_clone( return r; } - errno_pipe_fd[0] = -1; + errno_pipe_fd[0] = -EBADF; return 1; } diff --git a/src/machine/machine-dbus.c b/src/machine/machine-dbus.c index 75f397dd6b..1867893004 100644 --- a/src/machine/machine-dbus.c +++ b/src/machine/machine-dbus.c @@ -223,9 +223,9 @@ int bus_machine_method_get_addresses(sd_bus_message *message, void *userdata, sd } case MACHINE_CONTAINER: { - _cleanup_close_pair_ int pair[2] = { -1, -1 }; + _cleanup_close_pair_ int pair[2] = { -EBADF, -EBADF }; _cleanup_free_ char *us = NULL, *them = NULL; - _cleanup_close_ int netns_fd = -1; + _cleanup_close_ int netns_fd = -EBADF; const char *p; pid_t child; @@ -370,8 +370,8 @@ int bus_machine_method_get_os_release(sd_bus_message *message, void *userdata, s break; case MACHINE_CONTAINER: { - _cleanup_close_ int mntns_fd = -1, root_fd = -1, pidns_fd = -1; - _cleanup_close_pair_ int pair[2] = { -1, -1 }; + _cleanup_close_ int mntns_fd = -EBADF, root_fd = -EBADF, pidns_fd = -EBADF; + _cleanup_close_pair_ int pair[2] = { -EBADF, -EBADF }; _cleanup_fclose_ FILE *f = NULL; pid_t child; @@ -388,7 +388,7 @@ int bus_machine_method_get_os_release(sd_bus_message *message, void *userdata, s if (r < 0) return sd_bus_error_set_errnof(error, r, "Failed to fork(): %m"); if (r == 0) { - int fd = -1; + int fd = -EBADF; pair[0] = safe_close(pair[0]); @@ -888,9 +888,9 @@ int bus_machine_method_bind_mount(sd_bus_message *message, void *userdata, sd_bu int bus_machine_method_copy(sd_bus_message *message, void *userdata, sd_bus_error *error) { _cleanup_free_ char *host_basename = NULL, *container_basename = NULL; const char *src, *dest, *host_path, *container_path; - _cleanup_close_pair_ int errno_pipe_fd[2] = { -1, -1 }; + _cleanup_close_pair_ int errno_pipe_fd[2] = { -EBADF, -EBADF }; CopyFlags copy_flags = COPY_REFLINK|COPY_MERGE|COPY_HARDLINKS; - _cleanup_close_ int hostfd = -1; + _cleanup_close_ int hostfd = -EBADF; Machine *m = ASSERT_PTR(userdata); bool copy_from; pid_t child; @@ -1042,13 +1042,13 @@ int bus_machine_method_copy(sd_bus_message *message, void *userdata, sd_bus_erro (void) sigkill_wait(child); return r; } - errno_pipe_fd[0] = -1; + errno_pipe_fd[0] = -EBADF; return 1; } int bus_machine_method_open_root_directory(sd_bus_message *message, void *userdata, sd_bus_error *error) { - _cleanup_close_ int fd = -1; + _cleanup_close_ int fd = -EBADF; Machine *m = ASSERT_PTR(userdata); int r; @@ -1084,8 +1084,8 @@ int bus_machine_method_open_root_directory(sd_bus_message *message, void *userda break; case MACHINE_CONTAINER: { - _cleanup_close_ int mntns_fd = -1, root_fd = -1; - _cleanup_close_pair_ int pair[2] = { -1, -1 }; + _cleanup_close_ int mntns_fd = -EBADF, root_fd = -EBADF; + _cleanup_close_pair_ int pair[2] = { -EBADF, -EBADF }; pid_t child; r = namespace_open(m->leader, NULL, &mntns_fd, NULL, NULL, &root_fd); @@ -1100,7 +1100,7 @@ int bus_machine_method_open_root_directory(sd_bus_message *message, void *userda if (r < 0) return sd_bus_error_set_errnof(error, r, "Failed to fork(): %m"); if (r == 0) { - _cleanup_close_ int dfd = -1; + _cleanup_close_ int dfd = -EBADF; pair[0] = safe_close(pair[0]); diff --git a/src/machine/machinectl.c b/src/machine/machinectl.c index 93761a1da9..149b5d8e60 100644 --- a/src/machine/machinectl.c +++ b/src/machine/machinectl.c @@ -1800,7 +1800,7 @@ static int import_tar(int argc, char *argv[], void *userdata) { _cleanup_(sd_bus_message_unrefp) sd_bus_message *m = NULL; _cleanup_free_ char *ll = NULL, *fn = NULL; const char *local = NULL, *path = NULL; - _cleanup_close_ int fd = -1; + _cleanup_close_ int fd = -EBADF; sd_bus *bus = ASSERT_PTR(userdata); int r; @@ -1861,7 +1861,7 @@ static int import_raw(int argc, char *argv[], void *userdata) { _cleanup_(sd_bus_message_unrefp) sd_bus_message *m = NULL; _cleanup_free_ char *ll = NULL, *fn = NULL; const char *local = NULL, *path = NULL; - _cleanup_close_ int fd = -1; + _cleanup_close_ int fd = -EBADF; sd_bus *bus = ASSERT_PTR(userdata); int r; @@ -1922,7 +1922,7 @@ static int import_fs(int argc, char *argv[], void *userdata) { _cleanup_(sd_bus_message_unrefp) sd_bus_message *m = NULL; const char *local = NULL, *path = NULL; _cleanup_free_ char *fn = NULL; - _cleanup_close_ int fd = -1; + _cleanup_close_ int fd = -EBADF; sd_bus *bus = ASSERT_PTR(userdata); int r; @@ -1987,7 +1987,7 @@ static void determine_compression_from_filename(const char *p) { static int export_tar(int argc, char *argv[], void *userdata) { _cleanup_(sd_bus_message_unrefp) sd_bus_message *m = NULL; - _cleanup_close_ int fd = -1; + _cleanup_close_ int fd = -EBADF; const char *local = NULL, *path = NULL; sd_bus *bus = ASSERT_PTR(userdata); int r; @@ -2027,7 +2027,7 @@ static int export_tar(int argc, char *argv[], void *userdata) { static int export_raw(int argc, char *argv[], void *userdata) { _cleanup_(sd_bus_message_unrefp) sd_bus_message *m = NULL; - _cleanup_close_ int fd = -1; + _cleanup_close_ int fd = -EBADF; const char *local = NULL, *path = NULL; sd_bus *bus = ASSERT_PTR(userdata); int r; diff --git a/src/machine/machined-dbus.c b/src/machine/machined-dbus.c index 3da639279d..ed28627826 100644 --- a/src/machine/machined-dbus.c +++ b/src/machine/machined-dbus.c @@ -44,7 +44,7 @@ static int property_get_pool_usage( void *userdata, sd_bus_error *error) { - _cleanup_close_ int fd = -1; + _cleanup_close_ int fd = -EBADF; uint64_t usage = UINT64_MAX; assert(bus); @@ -70,7 +70,7 @@ static int property_get_pool_limit( void *userdata, sd_bus_error *error) { - _cleanup_close_ int fd = -1; + _cleanup_close_ int fd = -EBADF; uint64_t size = UINT64_MAX; assert(bus); @@ -683,8 +683,8 @@ static int method_clean_pool(sd_bus_message *message, void *userdata, sd_bus_err REMOVE_HIDDEN, } mode; - _cleanup_close_pair_ int errno_pipe_fd[2] = { -1, -1 }; - _cleanup_close_ int result_fd = -1; + _cleanup_close_pair_ int errno_pipe_fd[2] = { -EBADF, -EBADF }; + _cleanup_close_ int result_fd = -EBADF; Manager *m = userdata; Operation *operation; const char *mm; @@ -824,8 +824,8 @@ static int method_clean_pool(sd_bus_message *message, void *userdata, sd_bus_err operation->extra_fd = result_fd; operation->done = clean_pool_done; - result_fd = -1; - errno_pipe_fd[0] = -1; + result_fd = -EBADF; + errno_pipe_fd[0] = -EBADF; return 1; } diff --git a/src/machine/operation.c b/src/machine/operation.c index c97b29aba8..49b6d31bdc 100644 --- a/src/machine/operation.c +++ b/src/machine/operation.c @@ -81,7 +81,7 @@ int operation_new(Manager *manager, Machine *machine, pid_t child, sd_bus_messag if (!o) return -ENOMEM; - o->extra_fd = -1; + o->extra_fd = -EBADF; r = sd_event_add_child(manager->event, &o->event_source, child, WEXITED, operation_done, o); if (r < 0) { |