summaryrefslogtreecommitdiff
path: root/src/network
diff options
context:
space:
mode:
authorYu Watanabe <watanabe.yu+github@gmail.com>2022-11-30 10:22:39 +0900
committerYu Watanabe <watanabe.yu+github@gmail.com>2022-11-30 10:23:58 +0900
commit4bbe559b5c06387a56cb765076790a4bd47d0e82 (patch)
tree7004525c86fad766b32a300241d2958ea6fa8882 /src/network
parentaaad20e0e1066ae9efa51251ecfa1c30a14dd323 (diff)
downloadsystemd-4bbe559b5c06387a56cb765076790a4bd47d0e82.tar.gz
network: address: use ASSERT_PTR()
Diffstat (limited to 'src/network')
-rw-r--r--src/network/networkd-address.c20
1 files changed, 5 insertions, 15 deletions
diff --git a/src/network/networkd-address.c b/src/network/networkd-address.c
index e6db72f4f4..eae374323e 100644
--- a/src/network/networkd-address.c
+++ b/src/network/networkd-address.c
@@ -462,14 +462,9 @@ static int address_add(Link *link, Address *address) {
}
static int address_update(Address *address) {
- Link *link;
+ Link *link = ASSERT_PTR(ASSERT_PTR(address)->link);
int r;
- assert(address);
- assert(address->link);
-
- link = address->link;
-
if (address_is_ready(address) &&
address->family == AF_INET6 &&
in6_addr_is_link_local(&address->in_addr.in6) &&
@@ -485,7 +480,7 @@ static int address_update(Address *address) {
if (IN_SET(link->state, LINK_STATE_FAILED, LINK_STATE_LINGER))
return 0;
- r = address_set_masquerade(address, true);
+ r = address_set_masquerade(address, /* add = */ true);
if (r < 0)
return log_link_warning_errno(link, r, "Could not enable IP masquerading: %m");
@@ -497,21 +492,16 @@ static int address_update(Address *address) {
return r;
}
- link_update_operstate(link, true);
+ link_update_operstate(link, /* also_update_master = */ true);
link_check_ready(link);
return 0;
}
static int address_drop(Address *address) {
- Link *link;
+ Link *link = ASSERT_PTR(ASSERT_PTR(address)->link);
int r;
- assert(address);
- assert(address->link);
-
- link = address->link;
-
- r = address_set_masquerade(address, false);
+ r = address_set_masquerade(address, /* add = */ false);
if (r < 0)
log_link_warning_errno(link, r, "Failed to disable IP masquerading, ignoring: %m");