summaryrefslogtreecommitdiff
path: root/src/nspawn/nspawn-expose-ports.c
diff options
context:
space:
mode:
authorFlorian Westphal <fw@strlen.de>2020-06-19 13:33:19 +0200
committerLennart Poettering <lennart@poettering.net>2020-12-03 11:04:46 +0100
commit67b3732a533a55968727ff52bbce789e9f88501c (patch)
tree18b337e4b09280d6287de50ca45a42c767ddc287 /src/nspawn/nspawn-expose-ports.c
parent140105b73035a9109754ea0f4e7e0a06b866db6f (diff)
downloadsystemd-67b3732a533a55968727ff52bbce789e9f88501c.tar.gz
fw_add_local_dnat: remove unused function arguments
All users pass a NULL/0 for those, things haven't changed since 2015 when this was added originally, so remove the arguments. THe paramters are re-added as local function variables, initalised to NULL or 0. A followup patch can then manually remove all if (NULL) rather than leaving dead-branch optimization to compiler. Reason for not doing it here is to ease patch review. Not requiring support for this will ease initial nftables backend implementation. In case a use-case comues up later this feature can be re-added.
Diffstat (limited to 'src/nspawn/nspawn-expose-ports.c')
-rw-r--r--src/nspawn/nspawn-expose-ports.c6
1 files changed, 0 insertions, 6 deletions
diff --git a/src/nspawn/nspawn-expose-ports.c b/src/nspawn/nspawn-expose-ports.c
index d8a37a3399..d1e29d7b82 100644
--- a/src/nspawn/nspawn-expose-ports.c
+++ b/src/nspawn/nspawn-expose-ports.c
@@ -100,9 +100,6 @@ int expose_port_flush(ExposePort* l, union in_addr_union *exposed) {
r = fw_add_local_dnat(false,
af,
p->protocol,
- NULL,
- NULL, 0,
- NULL, 0,
p->host_port,
exposed,
p->container_port,
@@ -156,9 +153,6 @@ int expose_port_execute(sd_netlink *rtnl, ExposePort *l, union in_addr_union *ex
r = fw_add_local_dnat(true,
af,
p->protocol,
- NULL,
- NULL, 0,
- NULL, 0,
p->host_port,
&new_exposed,
p->container_port,