summaryrefslogtreecommitdiff
path: root/src/oom
diff options
context:
space:
mode:
authorBenjamin Berg <bberg@redhat.com>2022-02-07 17:34:21 +0100
committerLuca Boccassi <luca.boccassi@gmail.com>2022-02-07 21:33:50 +0000
commit100abbc650a075936aa2700a7b19790f7519fa23 (patch)
tree935b6661aeac32d920a9b812099be1ab31008419 /src/oom
parent8eb0c7917da9d991c299206a32ba83e560d90f42 (diff)
downloadsystemd-100abbc650a075936aa2700a7b19790f7519fa23.tar.gz
oom: Cleanup of information dump code after kill
This is a follow up to 29f4185a9cdc ("oomd: Dump top offenders after a kill action") to clean up the code a bit for review comments that happened after the code had been merged already.
Diffstat (limited to 'src/oom')
-rw-r--r--src/oom/oomd-util.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/src/oom/oomd-util.c b/src/oom/oomd-util.c
index 4d05f57a69..77718d9c9e 100644
--- a/src/oom/oomd-util.c
+++ b/src/oom/oomd-util.c
@@ -227,7 +227,7 @@ static int dump_kill_candidates(OomdCGroupContext **sorted, int n, int dump_unti
f = open_memstream_unlocked(&dump, &size);
if (!f)
- return -errno;;
+ return -errno;
fprintf(f, "Considered %d cgroups for killing, top candidates were:\n", n);
for (int i = 0; i < dump_until; i++)
@@ -237,8 +237,6 @@ static int dump_kill_candidates(OomdCGroupContext **sorted, int n, int dump_unti
if (r < 0)
return r;
- f = safe_fclose(f);
-
return log_dump(LOG_INFO, dump);
}