diff options
| author | Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl> | 2021-05-14 11:20:18 +0200 |
|---|---|---|
| committer | Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl> | 2021-05-14 16:26:52 +0200 |
| commit | b4d1227858fb507b3bc8dc0a5ba2e4fdc0d2606f (patch) | |
| tree | 2ab2d9b776905342c6c5ee9bb5c02141c2792652 /src/resolve/resolved-dns-query.c | |
| parent | e1004d0aba336d9ce2e7d1e12780530894ae5c14 (diff) | |
| download | systemd-b4d1227858fb507b3bc8dc0a5ba2e4fdc0d2606f.tar.gz | |
resolved: make counter for redirects smaller
It can never go above 16, so let's use a narrower type.
Order will be adjusted later to remove holes.
Diffstat (limited to 'src/resolve/resolved-dns-query.c')
| -rw-r--r-- | src/resolve/resolved-dns-query.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/src/resolve/resolved-dns-query.c b/src/resolve/resolved-dns-query.c index beb20592bd..d1bb686254 100644 --- a/src/resolve/resolved-dns-query.c +++ b/src/resolve/resolved-dns-query.c @@ -12,8 +12,10 @@ #define QUERIES_MAX 2048 #define AUXILIARY_QUERIES_MAX 64 +#define CNAME_REDIRECTS_MAX 16 assert_cc(AUXILIARY_QUERIES_MAX < UINT8_MAX); +assert_cc(CNAME_REDIRECTS_MAX < UINT8_MAX); static int dns_query_candidate_new(DnsQueryCandidate **ret, DnsQuery *q, DnsScope *s) { DnsQueryCandidate *c; @@ -984,9 +986,9 @@ static int dns_query_cname_redirect(DnsQuery *q, const DnsResourceRecord *cname) assert(q); - q->n_cname_redirects++; - if (q->n_cname_redirects > CNAME_REDIRECT_MAX) + if (q->n_cname_redirects >= CNAME_REDIRECTS_MAX) return -ELOOP; + q->n_cname_redirects++; r = dns_question_cname_redirect(q->question_idna, cname, &nq_idna); if (r < 0) |