diff options
| author | Lennart Poettering <lennart@poettering.net> | 2020-09-14 18:16:54 +0200 |
|---|---|---|
| committer | Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl> | 2020-09-14 21:42:22 +0200 |
| commit | 2a03b9ed21fdbbaef52d9405b46f4967165bef78 (patch) | |
| tree | d0a11dd7051b41cd0f02b21522543e87c65ffacb /src/run | |
| parent | ad0b610b0c1c2595c32b6235e7ac5ad7fba6e0aa (diff) | |
| download | systemd-2a03b9ed21fdbbaef52d9405b46f4967165bef78.tar.gz | |
tree-wide: don't needlessly negate error number passed to bus_error_message()
Like it's customary in our codebase bus_error_message() internally takes
abs() of the passed error anyway, hence no need to explicitly negate it.
We mostly got this right, but in too many cases we didn't. Fix that.
Diffstat (limited to 'src/run')
| -rw-r--r-- | src/run/run.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/run/run.c b/src/run/run.c index d4ce3966e7..38446d8814 100644 --- a/src/run/run.c +++ b/src/run/run.c @@ -1146,7 +1146,7 @@ static int start_transient_service( &pty_reply, "s", arg_host); if (r < 0) - return log_error_errno(r, "Failed to get machine PTY: %s", bus_error_message(&error, -r)); + return log_error_errno(r, "Failed to get machine PTY: %s", bus_error_message(&error, r)); r = sd_bus_message_read(pty_reply, "hs", &master, &s); if (r < 0) @@ -1468,7 +1468,7 @@ static int start_transient_scope(sd_bus *bus) { r = sd_bus_call(bus, m, 0, &error, &reply); if (r < 0) - return log_error_errno(r, "Failed to start transient scope unit: %s", bus_error_message(&error, -r)); + return log_error_errno(r, "Failed to start transient scope unit: %s", bus_error_message(&error, r)); r = sd_bus_message_read(reply, "o", &object); if (r < 0) @@ -1688,7 +1688,7 @@ static int start_transient_trigger( r = sd_bus_call(bus, m, 0, &error, &reply); if (r < 0) - return log_error_errno(r, "Failed to start transient %s unit: %s", suffix + 1, bus_error_message(&error, -r)); + return log_error_errno(r, "Failed to start transient %s unit: %s", suffix + 1, bus_error_message(&error, r)); r = sd_bus_message_read(reply, "o", &object); if (r < 0) |