summaryrefslogtreecommitdiff
path: root/src/shared/exec-util.c
diff options
context:
space:
mode:
authorChris Down <chris@chrisdown.name>2018-12-12 14:58:46 +0000
committerLennart Poettering <lennart@poettering.net>2018-12-12 20:47:40 +0100
commite92aaed30e0b5750e5633765f1bddd51c96678e5 (patch)
treeb568cc092a868d3a4226f529e943d3cde8e72f82 /src/shared/exec-util.c
parent9be3c605706cd8430e330e9d16df372f5daccce2 (diff)
downloadsystemd-e92aaed30e0b5750e5633765f1bddd51c96678e5.tar.gz
tree-wide: Remove O_CLOEXEC from fdopen
fdopen doesn't accept "e", it's ignored. Let's not mislead people into believing that it actually sets O_CLOEXEC. From `man 3 fdopen`: > e (since glibc 2.7): > Open the file with the O_CLOEXEC flag. See open(2) for more information. This flag is ignored for fdopen() As mentioned by @jlebon in #11131.
Diffstat (limited to 'src/shared/exec-util.c')
-rw-r--r--src/shared/exec-util.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/shared/exec-util.c b/src/shared/exec-util.c
index d66b300459..17a278a00f 100644
--- a/src/shared/exec-util.c
+++ b/src/shared/exec-util.c
@@ -308,7 +308,7 @@ static int gather_environment_consume(int fd, void *arg) {
assert(env);
- f = fdopen(fd, "re");
+ f = fdopen(fd, "r");
if (!f) {
safe_close(fd);
return -errno;