diff options
author | Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl> | 2021-04-14 17:44:47 +0200 |
---|---|---|
committer | Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl> | 2021-04-14 17:45:11 +0200 |
commit | 75029e150b47543b5c352298170847d39489c3fc (patch) | |
tree | 8ec02193e3bf1af9a5dc4d09a054fe0914f99380 /src/sleep | |
parent | a2eb2267e44580446ecad37e7206e729cfd78155 (diff) | |
download | systemd-75029e150b47543b5c352298170847d39489c3fc.tar.gz |
Do not try to return 0 from log_debug()
As @yuwata correctly points out, this became broken when log_debug()
started returning -EIO. I wanted to preserve this pattern, but it turns
out it is not very widely used, and preserving it would make the whole
thing, already quite complicated, even more complex.
log_debug() is made like log_info() and friends, and returns void.
Diffstat (limited to 'src/sleep')
-rw-r--r-- | src/sleep/sleep.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/src/sleep/sleep.c b/src/sleep/sleep.c index 262d4cea66..8aeaa1a543 100644 --- a/src/sleep/sleep.c +++ b/src/sleep/sleep.c @@ -163,10 +163,10 @@ static int lock_all_homes(void) { if (!bus_error_is_unknown_service(&error)) return log_error_errno(r, "Failed to lock home directories: %s", bus_error_message(&error, r)); - return log_debug("systemd-homed is not running, locking of home directories skipped."); - } - - return log_debug("Successfully requested locking of all home directories."); + log_debug("systemd-homed is not running, locking of home directories skipped."); + } else + log_debug("Successfully requested locking of all home directories."); + return 0; } static int execute(char **modes, char **states, const char *action) { |