diff options
author | Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl> | 2022-12-19 13:07:42 +0100 |
---|---|---|
committer | Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl> | 2022-12-19 15:00:57 +0100 |
commit | 254d1313ae5a69c08c9b93032aaaf3d6083cfc07 (patch) | |
tree | 067102a36abe6bf597c26a42d79018a1060c9007 /src/test/test-fdset.c | |
parent | cbff793ffb280d9d11e5d7b1dc3964276491bee8 (diff) | |
download | systemd-254d1313ae5a69c08c9b93032aaaf3d6083cfc07.tar.gz |
tree-wide: use -EBADF for fd initialization
-1 was used everywhere, but -EBADF or -EBADFD started being used in various
places. Let's make things consistent in the new style.
Note that there are two candidates:
EBADF 9 Bad file descriptor
EBADFD 77 File descriptor in bad state
Since we're initializating the fd, we're just assigning a value that means
"no fd yet", so it's just a bad file descriptor, and the first errno fits
better. If instead we had a valid file descriptor that became invalid because
of some operation or state change, the other errno would fit better.
In some places, initialization is dropped if unnecessary.
Diffstat (limited to 'src/test/test-fdset.c')
-rw-r--r-- | src/test/test-fdset.c | 16 |
1 files changed, 8 insertions, 8 deletions
diff --git a/src/test/test-fdset.c b/src/test/test-fdset.c index b6ad290eef..67c99d8501 100644 --- a/src/test/test-fdset.c +++ b/src/test/test-fdset.c @@ -10,7 +10,7 @@ #include "tmpfile-util.h" TEST(fdset_new_fill) { - int fd = -1; + int fd = -EBADF; _cleanup_fdset_free_ FDSet *fdset = NULL; char name[] = "/tmp/test-fdset_new_fill.XXXXXX"; @@ -23,8 +23,8 @@ TEST(fdset_new_fill) { } TEST(fdset_put_dup) { - _cleanup_close_ int fd = -1; - int copyfd = -1; + _cleanup_close_ int fd = -EBADF; + int copyfd = -EBADF; _cleanup_fdset_free_ FDSet *fdset = NULL; char name[] = "/tmp/test-fdset_put_dup.XXXXXX"; @@ -42,7 +42,7 @@ TEST(fdset_put_dup) { } TEST(fdset_cloexec) { - int fd = -1; + int fd = -EBADF; _cleanup_fdset_free_ FDSet *fdset = NULL; int flags = -1; char name[] = "/tmp/test-fdset_cloexec.XXXXXX"; @@ -68,8 +68,8 @@ TEST(fdset_cloexec) { } TEST(fdset_close_others) { - int fd = -1; - int copyfd = -1; + int fd = -EBADF; + int copyfd = -EBADF; _cleanup_fdset_free_ FDSet *fdset = NULL; int flags = -1; char name[] = "/tmp/test-fdset_close_others.XXXXXX"; @@ -92,7 +92,7 @@ TEST(fdset_close_others) { } TEST(fdset_remove) { - _cleanup_close_ int fd = -1; + _cleanup_close_ int fd = -EBADF; FDSet *fdset = NULL; char name[] = "/tmp/test-fdset_remove.XXXXXX"; @@ -112,7 +112,7 @@ TEST(fdset_remove) { } TEST(fdset_iterate) { - int fd = -1; + int fd = -EBADF; FDSet *fdset = NULL; char name[] = "/tmp/test-fdset_iterate.XXXXXX"; int c = 0; |