diff options
author | Louis Taylor <louis@kragniz.eu> | 2019-01-14 21:35:10 +0000 |
---|---|---|
committer | Louis Taylor <louis@kragniz.eu> | 2019-01-17 13:42:54 +0000 |
commit | e4a8db1fbd89592899f22fa68e9769e1afc98581 (patch) | |
tree | c19e5c9ef9cb3ea62d2021105b81a32268ead42d /src/test/test-fileio.c | |
parent | 80aff27aeb7bbe694395df56be300ff5a4ea4e02 (diff) | |
download | systemd-e4a8db1fbd89592899f22fa68e9769e1afc98581.tar.gz |
util-lib: follow shell syntax for escape in quotes
Fixes #10659.
This changes the behaviour of parsing environment files to more closely
follow POSIX shell standards.
This has the effect that these variables defined in a file:
VAR1='\value'
VAR2="\value"
Are now interpreted as `\value` instead of interpreting the `\`
character and interpreting them as `value`.
For more information about the behaviour followed, see:
http://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#tag_18_02
Diffstat (limited to 'src/test/test-fileio.c')
-rw-r--r-- | src/test/test-fileio.c | 34 |
1 files changed, 25 insertions, 9 deletions
diff --git a/src/test/test-fileio.c b/src/test/test-fileio.c index bf918c1d1e..2ddaabe7f8 100644 --- a/src/test/test-fileio.c +++ b/src/test/test-fileio.c @@ -26,7 +26,8 @@ static void test_parse_env_file(void) { p[] = "/tmp/test-fileio-out-XXXXXX"; FILE *f; _cleanup_free_ char *one = NULL, *two = NULL, *three = NULL, *four = NULL, *five = NULL, - *six = NULL, *seven = NULL, *eight = NULL, *nine = NULL, *ten = NULL; + *six = NULL, *seven = NULL, *eight = NULL, *nine = NULL, *ten = NULL, + *eleven = NULL, *twelve = NULL, *thirteen = NULL; _cleanup_strv_free_ char **a = NULL, **b = NULL; char **i; unsigned k; @@ -43,7 +44,7 @@ static void test_parse_env_file(void) { "three = \"333\n" "xxxx\"\n" "four = \'44\\\"44\'\n" - "five = \'55\\\'55\' \"FIVE\" cinco \n" + "five = \"55\\\"55\" \"FIVE\" cinco \n" "six = seis sechs\\\n" " sis\n" "seven=\"sevenval\" #nocomment\n" @@ -51,7 +52,10 @@ static void test_parse_env_file(void) { "export nine=nineval\n" "ten=ignored\n" "ten=ignored\n" - "ten=", f); + "ten=\n" + "eleven=\\value\n" + "twelve=\"\\value\"\n" + "thirteen='\\value'", f); fflush(f); fclose(f); @@ -65,14 +69,17 @@ static void test_parse_env_file(void) { assert_se(streq_ptr(a[0], "one=BAR")); assert_se(streq_ptr(a[1], "two=bar")); assert_se(streq_ptr(a[2], "three=333\nxxxx")); - assert_se(streq_ptr(a[3], "four=44\"44")); - assert_se(streq_ptr(a[4], "five=55\'55FIVEcinco")); + assert_se(streq_ptr(a[3], "four=44\\\"44")); + assert_se(streq_ptr(a[4], "five=55\"55FIVEcinco")); assert_se(streq_ptr(a[5], "six=seis sechs sis")); assert_se(streq_ptr(a[6], "seven=sevenval#nocomment")); assert_se(streq_ptr(a[7], "eight=eightval #nocomment")); assert_se(streq_ptr(a[8], "export nine=nineval")); assert_se(streq_ptr(a[9], "ten=")); - assert_se(a[10] == NULL); + assert_se(streq_ptr(a[10], "eleven=value")); + assert_se(streq_ptr(a[11], "twelve=\\value")); + assert_se(streq_ptr(a[12], "thirteen=\\value")); + assert_se(a[13] == NULL); strv_env_clean(a); @@ -93,7 +100,10 @@ static void test_parse_env_file(void) { "seven", &seven, "eight", &eight, "export nine", &nine, - "ten", &ten); + "ten", &ten, + "eleven", &eleven, + "twelve", &twelve, + "thirteen", &thirteen); assert_se(r >= 0); @@ -107,17 +117,23 @@ static void test_parse_env_file(void) { log_info("eight=[%s]", strna(eight)); log_info("export nine=[%s]", strna(nine)); log_info("ten=[%s]", strna(nine)); + log_info("eleven=[%s]", strna(eleven)); + log_info("twelve=[%s]", strna(twelve)); + log_info("thirteen=[%s]", strna(thirteen)); assert_se(streq(one, "BAR")); assert_se(streq(two, "bar")); assert_se(streq(three, "333\nxxxx")); - assert_se(streq(four, "44\"44")); - assert_se(streq(five, "55\'55FIVEcinco")); + assert_se(streq(four, "44\\\"44")); + assert_se(streq(five, "55\"55FIVEcinco")); assert_se(streq(six, "seis sechs sis")); assert_se(streq(seven, "sevenval#nocomment")); assert_se(streq(eight, "eightval #nocomment")); assert_se(streq(nine, "nineval")); assert_se(ten == NULL); + assert_se(streq(eleven, "value")); + assert_se(streq(twelve, "\\value")); + assert_se(streq(thirteen, "\\value")); { /* prepare a temporary file to write the environment to */ |