diff options
| author | Lennart Poettering <lennart@poettering.net> | 2022-05-04 10:53:00 +0200 |
|---|---|---|
| committer | Lennart Poettering <lennart@poettering.net> | 2022-05-04 13:29:14 +0200 |
| commit | db55bbf29b8d0268884348bf3270b8b2a2db3b31 (patch) | |
| tree | f17d57f6f02880a87ac4fb067768b797a0fe1d7b /src/test/test-stat-util.c | |
| parent | 080b8c2ace2dcc4ee3faf5b0ee95f5117aa27dab (diff) | |
| download | systemd-db55bbf29b8d0268884348bf3270b8b2a2db3b31.tar.gz | |
stat-util: fix dir_is_empty() with hidden/backup files
This is a follow-up for f470cb6d13558fc06131dc677d54a089a0b07359 which in
turn is a follow-up for a068aceafbffcba85398cce636c25d659265087a.
The latter started to honour hidden files when deciding whether a
directory is empty. The former reverted to the old behaviour to fix
issue #23220.
It introduced a bug though: when a directory contains a larger number of
hidden entries the getdents64() buffer will not suffice to read them,
since we just allocate three entries for it (which is definitely enough
if we just ignore the . + .. entries, but not ig we ignore more).
I think it's a bit confusing that dir_is_empty() can return true even if
rmdir() on the dir would return ENOTEMPTY. Hence, let's rework the
function to make it optional whether hidden files are ignored or not.
After all, I looking at the users of this function I am pretty sure in
more cases we want to honour hidden files.
Diffstat (limited to 'src/test/test-stat-util.c')
| -rw-r--r-- | src/test/test-stat-util.c | 20 |
1 files changed, 12 insertions, 8 deletions
diff --git a/src/test/test-stat-util.c b/src/test/test-stat-util.c index a8fdbb7c18..04d52d364f 100644 --- a/src/test/test-stat-util.c +++ b/src/test/test-stat-util.c @@ -153,17 +153,17 @@ TEST(dir_is_empty) { _cleanup_(rm_rf_physical_and_freep) char *empty_dir = NULL; _cleanup_free_ char *j = NULL, *jj = NULL, *jjj = NULL; - assert_se(dir_is_empty_at(AT_FDCWD, "/proc") == 0); - assert_se(dir_is_empty_at(AT_FDCWD, "/icertainlydontexistdoi") == -ENOENT); + assert_se(dir_is_empty_at(AT_FDCWD, "/proc", /* ignore_hidden_or_backup= */ true) == 0); + assert_se(dir_is_empty_at(AT_FDCWD, "/icertainlydontexistdoi", /* ignore_hidden_or_backup= */ true) == -ENOENT); assert_se(mkdtemp_malloc("/tmp/emptyXXXXXX", &empty_dir) >= 0); - assert_se(dir_is_empty_at(AT_FDCWD, empty_dir) > 0); + assert_se(dir_is_empty_at(AT_FDCWD, empty_dir, /* ignore_hidden_or_backup= */ true) > 0); j = path_join(empty_dir, "zzz"); assert_se(j); assert_se(touch(j) >= 0); - assert_se(dir_is_empty_at(AT_FDCWD, empty_dir) == 0); + assert_se(dir_is_empty_at(AT_FDCWD, empty_dir, /* ignore_hidden_or_backup= */ true) == 0); jj = path_join(empty_dir, "ppp"); assert_se(jj); @@ -173,13 +173,17 @@ TEST(dir_is_empty) { assert_se(jjj); assert_se(touch(jjj) >= 0); - assert_se(dir_is_empty_at(AT_FDCWD, empty_dir) == 0); + assert_se(dir_is_empty_at(AT_FDCWD, empty_dir, /* ignore_hidden_or_backup= */ true) == 0); + assert_se(dir_is_empty_at(AT_FDCWD, empty_dir, /* ignore_hidden_or_backup= */ false) == 0); assert_se(unlink(j) >= 0); - assert_se(dir_is_empty_at(AT_FDCWD, empty_dir) == 0); + assert_se(dir_is_empty_at(AT_FDCWD, empty_dir, /* ignore_hidden_or_backup= */ true) == 0); + assert_se(dir_is_empty_at(AT_FDCWD, empty_dir, /* ignore_hidden_or_backup= */ false) == 0); assert_se(unlink(jj) >= 0); - assert_se(dir_is_empty_at(AT_FDCWD, empty_dir) > 0); + assert_se(dir_is_empty_at(AT_FDCWD, empty_dir, /* ignore_hidden_or_backup= */ true) > 0); + assert_se(dir_is_empty_at(AT_FDCWD, empty_dir, /* ignore_hidden_or_backup= */ false) == 0); assert_se(unlink(jjj) >= 0); - assert_se(dir_is_empty_at(AT_FDCWD, empty_dir) > 0); + assert_se(dir_is_empty_at(AT_FDCWD, empty_dir, /* ignore_hidden_or_backup= */ true) > 0); + assert_se(dir_is_empty_at(AT_FDCWD, empty_dir, /* ignore_hidden_or_backup= */ false) > 0); } static int intro(void) { |