diff options
| author | Daniel Mack <daniel@zonque.org> | 2022-03-22 18:26:55 +0100 |
|---|---|---|
| committer | Yu Watanabe <watanabe.yu+github@gmail.com> | 2022-04-09 10:23:14 +0900 |
| commit | feb219c99714f5bd0b632d1699d24bbd34225ca4 (patch) | |
| tree | dd9fd237f5f222986dd17b731ffda7a22efdbfd5 /src/timesync/timesyncd-server.c | |
| parent | 5dfb11097d141dcab711fa62b5e951561038640a (diff) | |
| download | systemd-feb219c99714f5bd0b632d1699d24bbd34225ca4.tar.gz | |
timesyncd: clean up server_name_new()
Use `LIST_APPEND()` in favour of `LIST_FIND_TAIL()` + `LIST_INSERT_AFTER()`.
Also use a switch/case statement instead of if/else if.
Diffstat (limited to 'src/timesync/timesyncd-server.c')
| -rw-r--r-- | src/timesync/timesyncd-server.c | 30 |
1 files changed, 16 insertions, 14 deletions
diff --git a/src/timesync/timesyncd-server.c b/src/timesync/timesyncd-server.c index c8ff46f399..3b7d79323f 100644 --- a/src/timesync/timesyncd-server.c +++ b/src/timesync/timesyncd-server.c @@ -66,7 +66,7 @@ int server_name_new( ServerType type, const char *string) { - ServerName *n, *tail; + ServerName *n; assert(m); assert(string); @@ -86,20 +86,22 @@ int server_name_new( return -ENOMEM; } - if (type == SERVER_SYSTEM) { - LIST_FIND_TAIL(names, m->system_servers, tail); - LIST_INSERT_AFTER(names, m->system_servers, tail, n); - } else if (type == SERVER_LINK) { - LIST_FIND_TAIL(names, m->link_servers, tail); - LIST_INSERT_AFTER(names, m->link_servers, tail, n); - } else if (type == SERVER_FALLBACK) { - LIST_FIND_TAIL(names, m->fallback_servers, tail); - LIST_INSERT_AFTER(names, m->fallback_servers, tail, n); - } else if (type == SERVER_RUNTIME) { - LIST_FIND_TAIL(names, m->runtime_servers, tail); - LIST_INSERT_AFTER(names, m->runtime_servers, tail, n); - } else + switch (type) { + case SERVER_SYSTEM: + LIST_APPEND(names, m->system_servers, n); + break; + case SERVER_LINK: + LIST_APPEND(names, m->link_servers, n); + break; + case SERVER_FALLBACK: + LIST_APPEND(names, m->fallback_servers, n); + break; + case SERVER_RUNTIME: + LIST_APPEND(names, m->runtime_servers, n); + break; + default: assert_not_reached(); + } if (type != SERVER_FALLBACK && m->current_server_name && |