diff options
author | Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl> | 2018-05-14 09:20:17 +0200 |
---|---|---|
committer | Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl> | 2018-05-14 17:22:22 +0200 |
commit | 9421cab6db41498f476c5fa2f1c745b6cf15ec97 (patch) | |
tree | 7b481e0d6ef825f932f5b9554c735bd41d314d00 /src | |
parent | dcd6361ea1dfaa6810b480e0bc53674e5b2c822d (diff) | |
download | systemd-9421cab6db41498f476c5fa2f1c745b6cf15ec97.tar.gz |
test-copy: remove unnecessary initialization
Initializing just some of the values doesn't make sense. We should handle them
all in the same way. In those tests there are no jumps, all steps are covered
with assert_se(), so we know everything will be set if we get to the end of the
function. And _not_ initializing those variables has the advantage that it
allows valgrind to catch potential initalization errors in the function being
tested.
Diffstat (limited to 'src')
-rw-r--r-- | src/test/test-copy.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/test/test-copy.c b/src/test/test-copy.c index 6b5d1e152d..a02746c76d 100644 --- a/src/test/test-copy.c +++ b/src/test/test-copy.c @@ -117,8 +117,8 @@ static void test_copy_tree(void) { assert_se(copy_tree(original_dir, copy_dir, UID_INVALID, GID_INVALID, COPY_REFLINK|COPY_MERGE) == 0); STRV_FOREACH(p, files) { - _cleanup_free_ char *buf = NULL, *f; - size_t sz = 0; + _cleanup_free_ char *buf, *f; + size_t sz; assert_se(f = strappend(copy_dir, *p)); @@ -128,7 +128,7 @@ static void test_copy_tree(void) { } STRV_FOREACH_PAIR(link, p, links) { - _cleanup_free_ char *target = NULL, *f, *l; + _cleanup_free_ char *target, *f, *l; assert_se(f = strjoin(original_dir, *p)); assert_se(l = strjoin(copy_dir, *link)); |