summaryrefslogtreecommitdiff
path: root/units/user@.service.in
diff options
context:
space:
mode:
authorZbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>2020-03-04 14:21:37 +0100
committerYu Watanabe <watanabe.yu+github@gmail.com>2020-03-05 04:49:37 +0900
commita3558e795203230837fb3afc64102fa501b001d4 (patch)
treee1a6d938922780bb5859bc22c4c574923e512dd2 /units/user@.service.in
parentdf883de98a885da27ab2098e5712409e5bd8b18e (diff)
downloadsystemd-a3558e795203230837fb3afc64102fa501b001d4.tar.gz
units: do not ignore return value from systemd --user
This minus has been there since the unit was added in d42d27ead91e470cb12986d928441e56c0f543ca. I think the idea was not cause things to fail if the user instance doesn't work. But ignoring the return value doesn't seem to be the right way to approach the problem. In particular, if the program fails to run, we'll get a bogus fail state, see https://bugzilla.redhat.com/show_bug.cgi?id=1727895#c1: with the minus: $ systemctl start user@1002 Job for user@1002.service failed because the service did not take the steps required by its unit configuration. See "systemctl status user@1002.service" and "journalctl -xe" for details. without the minus: $ systemctl start user@1002 Job for user@1002.service failed because the control process exited with error code. See "systemctl status user@1002.service" and "journalctl -xe" for details.
Diffstat (limited to 'units/user@.service.in')
-rw-r--r--units/user@.service.in2
1 files changed, 1 insertions, 1 deletions
diff --git a/units/user@.service.in b/units/user@.service.in
index e898b39783..ace24369dd 100644
--- a/units/user@.service.in
+++ b/units/user@.service.in
@@ -18,7 +18,7 @@ IgnoreOnIsolate=yes
User=%i
PAMName=systemd-user
Type=notify
-ExecStart=-@rootlibexecdir@/systemd --user
+ExecStart=@rootlibexecdir@/systemd --user
Slice=user-%i.slice
KillMode=mixed
Delegate=pids memory