summaryrefslogtreecommitdiff
path: root/coccinelle/take-fd.cocci
diff options
context:
space:
mode:
Diffstat (limited to 'coccinelle/take-fd.cocci')
-rw-r--r--coccinelle/take-fd.cocci9
1 files changed, 8 insertions, 1 deletions
diff --git a/coccinelle/take-fd.cocci b/coccinelle/take-fd.cocci
index ba242483cd..f7124e7896 100644
--- a/coccinelle/take-fd.cocci
+++ b/coccinelle/take-fd.cocci
@@ -6,8 +6,15 @@ expression q;
- q = -1;
- return p;
+ return TAKE_FD(q);
+
+/* The ideal solution would use 'local idexpression' to avoid matching errno,
+ * which is a global variable. However, 'idexpression' nor 'identifier'
+ * would match, for example, "x->fd", which is considered 'expression' in
+ * the SmPL grammar
+ */
@@
-expression p, q;
+expression p != errno;
+expression q;
@@
- p = q;
- q = -1;