diff options
| author | Denis Ovsienko <denis@ovsienko.info> | 2018-07-23 23:28:24 +0100 |
|---|---|---|
| committer | Denis Ovsienko <denis@ovsienko.info> | 2019-11-03 23:46:28 +0000 |
| commit | c9e5ac541bbb4f01af0a6545fafe6c181d1eebbb (patch) | |
| tree | 4fb07ed4169c357dd94939e69c482b4d426a01ff /cmakeconfig.h.in | |
| parent | eabcd87c1dc79255cbde14ef4559b327bb90d01e (diff) | |
| download | tcpdump-c9e5ac541bbb4f01af0a6545fafe6c181d1eebbb.tar.gz | |
libdnet has bugs, do not use it.
The only function tcpdump used in libdnet was dnet_htoa(), which tries
to translate a binary DECnet address to a nodename through a lookup in
/etc/decnet.conf. The translation is slow and has a bug, so stop using
the function and remove the dependency on libdnet.
This makes tcpdump always print DECnet addresses in numeric format, if
anybody needs the translation back they are welcome to fix libdnet or
(more realistically) add an implementation of dnet_htoa() to the tcpdump
source code and use it.
(This is a forward-port of commit 9a6eb27 from tcpdump-4.9 to master.
Sadly, together with libdnet this change removes the fine work that Guy
had done in the master branch in commits ebf3f19 and 4ef8d63 to put
libdnet usage right whilst my original "do not use libdnet" commit was
aging in the pipeline.)
Diffstat (limited to 'cmakeconfig.h.in')
| -rw-r--r-- | cmakeconfig.h.in | 15 |
1 files changed, 0 insertions, 15 deletions
diff --git a/cmakeconfig.h.in b/cmakeconfig.h.in index 5c753284..38925d7b 100644 --- a/cmakeconfig.h.in +++ b/cmakeconfig.h.in @@ -30,9 +30,6 @@ /* Define to 1 if you have the declaration of `ether_ntohost' */ #cmakedefine HAVE_DECL_ETHER_NTOHOST 1 -/* define if you have the dnet_htoa function */ -#cmakedefine HAVE_DNET_HTOA 1 - /* Define to 1 if you have the `ether_ntohost' function. */ #cmakedefine HAVE_ETHER_NTOHOST 1 @@ -72,12 +69,6 @@ /* Define to 1 if you have the <memory.h> header file. */ #cmakedefine HAVE_MEMORY_H 1 -/* Define to 1 if you have the <netdnet/dnetdb.h> header file. */ -#cmakedefine HAVE_NETDNET_DNETDB_H 1 - -/* Define to 1 if you have the <netdnet/dn.h> header file. */ -#cmakedefine HAVE_NETDNET_DN_H 1 - /* Define to 1 if you have the <net/if.h> header file. */ #cmakedefine HAVE_NET_IF_H 1 @@ -213,9 +204,6 @@ /* Define to 1 if you have the `strsep' function. */ #cmakedefine HAVE_STRSEP 1 -/* Define to 1 if the system has the type `struct dn_naddr'. */ -#cmakedefine HAVE_STRUCT_DN_NADDR 1 - /* Define to 1 if the system has the type `struct ether_addr'. */ #cmakedefine HAVE_STRUCT_ETHER_ADDR 1 @@ -240,9 +228,6 @@ /* define if libpcap has yydebug */ #cmakedefine HAVE_YYDEBUG 1 -/* Define to 1 if netenet/dnetdb.h declares `dnet_htoa' */ -#cmakedefine NETDNET_DNETDB_H_DECLARES_DNET_HTOA 1 - /* Define to 1 if netinet/ether.h declares `ether_ntohost' */ #cmakedefine NETINET_ETHER_H_DECLARES_ETHER_NTOHOST 1 |