summaryrefslogtreecommitdiff
path: root/print-lane.c
diff options
context:
space:
mode:
authorguy <guy>2005-11-13 12:12:41 +0000
committerguy <guy>2005-11-13 12:12:41 +0000
commitdd928cfb35d7ceeacf55dd880ffc9673ac8809e7 (patch)
tree199addded786551dd05b060773db9f797ab335b6 /print-lane.c
parent86f96f8a7be545190da718a2908928d185e26d76 (diff)
downloadtcpdump-dd928cfb35d7ceeacf55dd880ffc9673ac8809e7.tar.gz
Have print_llc() clear out the extracted_ethertype argument, rather than
having its callers do so - some of its callers *weren't* doing so, leaving random junk in that argument in some cases. When checking for "802.3-encapsulated" IPX, check the raw values of the SSAP and DSAP for 0xFF, don't check them after the low-order bit has been masked off. The "flag" values in the LLC header aren't bits, they're combinations of bits, including the combination "no bits"; don't use "bittok2str()" on them. Also, combine the proper bits, namely the C/R bit (which we weren't combining) and the P/F bit (which we were).
Diffstat (limited to 'print-lane.c')
-rw-r--r--print-lane.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/print-lane.c b/print-lane.c
index ab03a44a..33723aaa 100644
--- a/print-lane.c
+++ b/print-lane.c
@@ -22,7 +22,7 @@
#ifndef lint
static const char rcsid[] _U_ =
- "@(#) $Header: /tcpdump/master/tcpdump/print-lane.c,v 1.24 2005-07-07 01:22:19 guy Exp $ (LBL)";
+ "@(#) $Header: /tcpdump/master/tcpdump/print-lane.c,v 1.25 2005-11-13 12:12:42 guy Exp $ (LBL)";
#endif
#ifdef HAVE_CONFIG_H
@@ -134,7 +134,6 @@ lane_print(const u_char *p, u_int length, u_int caplen)
/*
* Is it (gag) an 802.3 encapsulation?
*/
- extracted_ethertype = 0;
if (ether_type <= ETHERMTU) {
/* Try to print the LLC-layer header & higher layers */
if (llc_print(p, length, caplen, ep->h_source, ep->h_dest,