diff options
| author | guy <guy> | 2002-12-18 08:53:18 +0000 |
|---|---|---|
| committer | guy <guy> | 2002-12-18 08:53:18 +0000 |
| commit | e070cf232ffadbdbbca68b132ef369675890e566 (patch) | |
| tree | 7695fa04e8833fd19a5461409caa9c85f7717763 /print-pflog.c | |
| parent | c284d10cf4a5a2732b6a08036438f8b7611d67fb (diff) | |
| download | tcpdump-e070cf232ffadbdbbca68b132ef369675890e566.tar.gz | |
We no longer use "packetp" for anything, so eliminate it. (If any
dissector really needs source and destination MAC addresses, we should
make global pointers to them - which would be null for packets lacking
MAC addresses, so dissectors that need them will need to do something
sensible if those pointers are null.)
Don't fake up an Ethernet header if there aren't any MAC addresses to
use when faking it up.
"bp_chaddr" in "print-bootp.c" is an array, so "bp->bp_chaddr" cannot be
null, and there's no need to test for it not being null.
Diffstat (limited to 'print-pflog.c')
| -rw-r--r-- | print-pflog.c | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/print-pflog.c b/print-pflog.c index b8485ea5..f122a5a3 100644 --- a/print-pflog.c +++ b/print-pflog.c @@ -23,7 +23,7 @@ #ifndef lint static const char rcsid[] = - "@(#) $Header: /tcpdump/master/tcpdump/print-pflog.c,v 1.4 2002-09-05 21:25:44 guy Exp $ (LBL)"; + "@(#) $Header: /tcpdump/master/tcpdump/print-pflog.c,v 1.5 2002-12-18 08:53:22 guy Exp $ (LBL)"; #endif #ifdef HAVE_CONFIG_H @@ -113,11 +113,10 @@ pflog_if_print(u_char *user _U_, const struct pcap_pkthdr *h, } /* - * Some printers want to get back at the link level addresses, - * and/or check that they're not walking off the end of the packet. - * Rather than pass them all the way down, we set these globals. + * Some printers want to check that they're not walking off the + * end of the packet. + * Rather than pass it all the way down, we set this global. */ - packetp = p; snapend = p + caplen; hdr = (const struct pfloghdr *)p; |