summaryrefslogtreecommitdiff
path: root/print-telnet.c
diff options
context:
space:
mode:
authorFrancois-Xavier Le Bail <devel.fx.lebail@orange.fr>2020-08-10 16:22:37 +0200
committerFrancois-Xavier Le Bail <devel.fx.lebail@orange.fr>2020-09-05 14:59:21 +0200
commit929e4be621ebdcede37865a5767a175f083f9138 (patch)
treebf6ecbc038696e66176b2d50e04e015767f23b3d /print-telnet.c
parent54b5db3dde658894be730b15480f9b6e27b717a0 (diff)
downloadtcpdump-test-rc.tar.gz
Remove many (761) redundant ND_TCHECK_n() callstest-rc
ND_TCHECK_n(e), n in { 1, 2, 3, 4, 8 }. They are redundant because they are followed by a GET_.*_n(e) call, same n, same e, which do the bounds check. Remove unused 'trunc' labels and most associated codes. Update the outputs of some tests accordingly.
Diffstat (limited to 'print-telnet.c')
-rw-r--r--print-telnet.c3
1 files changed, 0 insertions, 3 deletions
diff --git a/print-telnet.c b/print-telnet.c
index 8dd5f2d6..5b2a785e 100644
--- a/print-telnet.c
+++ b/print-telnet.c
@@ -396,7 +396,6 @@ telnet_parse(netdissect_options *ndo, const u_char *sp, u_int length, int print)
do { \
if (length < 1) \
goto pktend; \
- ND_TCHECK_1(sp); \
c = GET_U_1(sp); \
sp++; \
length--; \
@@ -443,7 +442,6 @@ telnet_parse(netdissect_options *ndo, const u_char *sp, u_int length, int print)
break;
p++;
}
- ND_TCHECK_1(p);
if (GET_U_1(p) != IAC)
goto pktend;
@@ -516,7 +514,6 @@ telnet_print(netdissect_options *ndo, const u_char *sp, u_int length)
ndo->ndo_protocol = "telnet";
osp = sp;
- ND_TCHECK_1(sp);
while (length > 0 && GET_U_1(sp) == IAC) {
/*
* Parse the Telnet command without printing it,