diff options
author | Jonny Lamb <jonny.lamb@collabora.co.uk> | 2011-11-18 10:41:24 +0000 |
---|---|---|
committer | Jonny Lamb <jonny.lamb@collabora.co.uk> | 2011-11-18 10:41:24 +0000 |
commit | 717db63a6ed18186670fb7f97ddc5a2e15c82937 (patch) | |
tree | 224b01bea86939798f6e7d2214e6bf96562723c5 /.gitignore | |
parent | b3f50e345e8dabb2c620420e5889a2167935ffd7 (diff) | |
download | telepathy-glib-717db63a6ed18186670fb7f97ddc5a2e15c82937.tar.gz |
ft-channel: ensure incoming connections are actually closed (and not leaked)
Previously, we were getting the GSocketConnection and using it, but
once the splice operation was complete, we were only closing one side
of it, and then leaking the object in the process.
This is a problem because CMs can wait for EOF on the stream (like
salut) so if the stream isn't closed properly transfers can hang. It
wasn't noticed properly before because other CMs automatically close
the connection when the number of received bytes looks sane (like
gabble).
And yes, also we were leaking the GSocketConnection object.
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
Diffstat (limited to '.gitignore')
0 files changed, 0 insertions, 0 deletions