diff options
author | Xavier Claessens <xclaesse@gmail.com> | 2011-11-16 14:08:45 +0100 |
---|---|---|
committer | Xavier Claessens <xclaesse@gmail.com> | 2011-11-16 14:36:51 +0100 |
commit | 67bffca0678d1286d07b1531f6562126e92cc31e (patch) | |
tree | 309fa93328b63d8c1a90432bc1c697b4a97beba0 /telepathy-glib/base-password-channel.c | |
parent | e6d8b4c7531688cd2dbd3c9bbd8a6c224123de05 (diff) | |
download | telepathy-glib-67bffca0678d1286d07b1531f6562126e92cc31e.tar.gz |
Use _unref instead of _free _destroy when possible.
Replace g_(ptr_)array_free (foo, TRUE) and g_hash_table_destroy
with respectively g_(ptr_)array_unref (foo) and g_hash_table_unref.
I used this command to generate this patch:
for f in `find -name "*.c"`; do sed -i $f -re 's/g_ptr_array_free \(([^ ,]+), TRUE\)/g_ptr_array_unref \(\1\)/'; done
See Danielle's blog for explanation of possible bug _free can do:
http://blogs.gnome.org/danni/2011/11/16/mistakes-with-g_value_set_boxed/
Diffstat (limited to 'telepathy-glib/base-password-channel.c')
-rw-r--r-- | telepathy-glib/base-password-channel.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/telepathy-glib/base-password-channel.c b/telepathy-glib/base-password-channel.c index 6aca38ce2..c85eda83d 100644 --- a/telepathy-glib/base-password-channel.c +++ b/telepathy-glib/base-password-channel.c @@ -409,7 +409,7 @@ tp_base_password_channel_finalize (GObject *object) TpBasePasswordChannel *self = TP_BASE_PASSWORD_CHANNEL (object); TpBasePasswordChannelPrivate *priv = self->priv; - tp_clear_pointer (&priv->sasl_error_details, g_hash_table_destroy); + tp_clear_pointer (&priv->sasl_error_details, g_hash_table_unref); tp_clear_pointer (&priv->sasl_error, g_free); tp_clear_pointer (&priv->authorization_identity, g_free); tp_clear_pointer (&priv->default_username, g_free); |