summaryrefslogtreecommitdiff
path: root/telepathy-glib/connection-handles.c
diff options
context:
space:
mode:
authorSimon McVittie <simon.mcvittie@collabora.co.uk>2008-10-07 16:43:18 +0100
committerSimon McVittie <simon.mcvittie@collabora.co.uk>2008-10-13 12:57:35 +0100
commitb9e30965b02a4499c0e5b691022d6a1a189bcdd7 (patch)
treeca00d7bc113006814068a9044e3bfdd72c4622a2 /telepathy-glib/connection-handles.c
parent29fea105dccdbfe37cae9f3abbf258024fcde658 (diff)
downloadtelepathy-glib-b9e30965b02a4499c0e5b691022d6a1a189bcdd7.tar.gz
Amend a comment to indicate that no, we can't combine unrefs via g_idle_add
Diffstat (limited to 'telepathy-glib/connection-handles.c')
-rw-r--r--telepathy-glib/connection-handles.c6
1 files changed, 4 insertions, 2 deletions
diff --git a/telepathy-glib/connection-handles.c b/telepathy-glib/connection-handles.c
index 1527ac546..f3c0671ea 100644
--- a/telepathy-glib/connection-handles.c
+++ b/telepathy-glib/connection-handles.c
@@ -285,8 +285,10 @@ tp_connection_unref_handles (TpConnection *self,
}
}
- /* fire off the unref call asynchronously, ignore error if any.
- * FIXME: perhaps this should be done idly, so we can combine unrefs? */
+ /* Fire off the unref call asynchronously, ignore error if any.
+ * This can't be done idly (so we can combine unrefs) without additional
+ * checks, since that would introduce a race between the idle handler
+ * running, and someone else holding the handles again. */
if (unref->len > 0)
{
DEBUG ("releasing %u handles", unref->len);