diff options
| author | Simon McVittie <simon.mcvittie@collabora.co.uk> | 2012-02-01 19:30:39 +0000 |
|---|---|---|
| committer | Simon McVittie <simon.mcvittie@collabora.co.uk> | 2012-04-12 11:37:05 +0100 |
| commit | c6ed9fa480ed859dd7d111f6412b3a43a8cd73ca (patch) | |
| tree | c08a2f1bfaa1922b13b0e7926ab595c94dc47022 /telepathy-glib/contact.c | |
| parent | aa273c1835bb84766fb9e2b933677ef9fb79dd09 (diff) | |
| download | telepathy-glib-c6ed9fa480ed859dd7d111f6412b3a43a8cd73ca.tar.gz | |
Complete results of TpProxy D-Bus calls in an idle
GAsyncResult guarantees to call your callback from the main loop.
For historical reasons (basically "5 years ago I didn't know any
better"), TpProxy does not: if the interface is missing or the proxy
has been invalidated, the callback is called re-entrantly. I'm going
to fix that in Telepathy 1.0, but for now, let's give GAsyncResult
the correct semantics.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=45514
Reviewed-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
Diffstat (limited to 'telepathy-glib/contact.c')
| -rw-r--r-- | telepathy-glib/contact.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/telepathy-glib/contact.c b/telepathy-glib/contact.c index 185494544..3a73a9e0a 100644 --- a/telepathy-glib/contact.c +++ b/telepathy-glib/contact.c @@ -698,7 +698,7 @@ set_contact_groups_cb (TpConnection *connection, g_simple_async_result_set_from_error (result, error); } - g_simple_async_result_complete (result); + g_simple_async_result_complete_in_idle (result); g_object_unref (result); } |