diff options
author | Xavier Claessens <xclaesse@gmail.com> | 2011-11-16 14:08:45 +0100 |
---|---|---|
committer | Xavier Claessens <xclaesse@gmail.com> | 2011-11-16 14:36:51 +0100 |
commit | 67bffca0678d1286d07b1531f6562126e92cc31e (patch) | |
tree | 309fa93328b63d8c1a90432bc1c697b4a97beba0 /telepathy-glib/proxy.c | |
parent | e6d8b4c7531688cd2dbd3c9bbd8a6c224123de05 (diff) | |
download | telepathy-glib-67bffca0678d1286d07b1531f6562126e92cc31e.tar.gz |
Use _unref instead of _free _destroy when possible.
Replace g_(ptr_)array_free (foo, TRUE) and g_hash_table_destroy
with respectively g_(ptr_)array_unref (foo) and g_hash_table_unref.
I used this command to generate this patch:
for f in `find -name "*.c"`; do sed -i $f -re 's/g_ptr_array_free \(([^ ,]+), TRUE\)/g_ptr_array_unref \(\1\)/'; done
See Danielle's blog for explanation of possible bug _free can do:
http://blogs.gnome.org/danni/2011/11/16/mistakes-with-g_value_set_boxed/
Diffstat (limited to 'telepathy-glib/proxy.c')
-rw-r--r-- | telepathy-glib/proxy.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/telepathy-glib/proxy.c b/telepathy-glib/proxy.c index 0a0b6dce7..e1e102624 100644 --- a/telepathy-glib/proxy.c +++ b/telepathy-glib/proxy.c @@ -364,7 +364,7 @@ tp_proxy_prepare_request_finish (TpProxyPrepareRequest *req, g_object_unref (req->result); } - g_array_free (req->features, TRUE); + g_array_unref (req->features); g_slice_free (TpProxyPrepareRequest, req); } @@ -1083,7 +1083,7 @@ tp_proxy_constructor (GType type, g_type_name (ancestor_type)); } - g_array_free (core_features, TRUE); + g_array_unref (core_features); } g_return_val_if_fail (self->dbus_connection != NULL, NULL); |