| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
| |
|
|
|
|
|
| |
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=69849
Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk>
|
|
|
|
|
|
|
|
|
|
|
| |
As well as being less code, they're not flagged as deprecated.
This requires a bit of extra copying, because there's no
tp_value_array_unpack_dup() or tp_value_array_build_take(), but
it seems worth it.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=69849
Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk>
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
| |
Since we added async handle normalization functions, RequestHandles(1, [])
would just not return at all.
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
|
| |
|
|
|
|
|
|
| |
Calling set_size on the GArray is a little overkill.
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
|
|
|
|
|
|
|
| |
gtk-doc gets confused, so they've been removed from the docs. See
also: e8f9a27a388e21
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
|
|
|
|
|
|
| |
This is a lot like 74bd945252.
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
|
|
|
|
| |
https://bugs.freedesktop.org/show_bug.cgi?id=50341
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
| |
tp_connection_unref_handles()
They are no-op now, so we can safely remove them all
|
| |
|
| |
|
|
|
|
|
|
|
|
| |
Gabble hasn't done this since 2009, and this function has been removed
from the public API on 'next' (it interferes with separating tp_svc_*
out of the main library).
Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk>
|
|
|
|
| |
We deprecated this in 0.11.
|
|
|
|
| |
TpBaseConnection has to support it for backwards compatibility.
|
|
|
|
|
| |
Reviewed-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=30422
|
|
|
|
|
|
| |
Based on a patch from Jonny Lamb, updated for current master.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=46470
|
|
|
|
|
|
|
|
| |
fd.o#48363 was opened which complains about lots of documentation
problems (which g-ir-scanner finds). While I was at it I did some
grepping to find yet more problems.
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
|
|
|
|
|
|
|
|
| |
In contrast to the previous commit, I'm just using NULL here -
telepathy-glib has an explicit dependency on GLib 2.30.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=46523
Reviewed-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
|
|
|
|
|
|
|
|
| |
Many didn't use this shorthand, and some even didn't declare one of the
three strings as static (causing GObject to copy it).
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Vivek Dasmohapatra <vivek@collabora.co.uk>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We still have multiple gtk-doc warnings which are much harder to fix,
such as things like this in the spec:
"see bug #26417"
html/telepathy-glib-channel-text.html:1538: warning: no link for: '26417:CAPS' -> (<span class="type">26417</span>).
and the change I made to the code generator in c0b13f7ccc26e78.
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
|
|
|
|
|
|
|
|
|
|
|
| |
Replace g_(ptr_)array_free (foo, TRUE) and g_hash_table_destroy
with respectively g_(ptr_)array_unref (foo) and g_hash_table_unref.
I used this command to generate this patch:
for f in `find -name "*.c"`; do sed -i $f -re 's/g_ptr_array_free \(([^ ,]+), TRUE\)/g_ptr_array_unref \(\1\)/'; done
See Danielle's blog for explanation of possible bug _free can do:
http://blogs.gnome.org/danni/2011/11/16/mistakes-with-g_value_set_boxed/
|
|
|
|
| |
We have a couple more synthesized properties these days.
|
|
|
|
|
| |
It is indeed guaranteed to be non-NULL because of the above: in fact,
the above set it to a non-NULL value in the handle != 0 case.
|
|
|
|
| |
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
|
|
|
|
|
|
| |
This used to be done to change the debug flag used for
handle-reference-related code. But because handles are immortal now,
these functions have no DEBUG() statements at all.
|
|\
| |
| |
| | |
Reviewed-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
|
| |
| |
| |
| |
| |
| |
| | |
I don't think any of these have ever been of use to me. Including the
address of the object in the debug output once seems fine.
This shaves another 3% off the Gabble test suite debug output.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
are checked
If the caller makes an invalid state change, we shouldn't allow the
status to be updated, for instance from DISCONNECTED to CONNECTED if
success and failure race with each other and failure wins, as seen in
fd.o #37078; we should just emit the critical warning and leave it
DISCONNECTED.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=37079
Reviewed-by: Vivek Dasmohapatra <vivek@collabora.co.uk>
|
| | |
|
| | |
|
|/ |
|
|
|
|
| |
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I have a Gabble currently running with four open connections but only
one corresponding bus name. Here's what I think happened:
• I undocked my laptop. This got rid of the wired connection, but MC
doesn't notice so the connections stayed open.
• I switched to Offline in Empathy. This made MC call Disconnect() on
Gabble. The connection released its bus name (because tp-glib does
this in change_status(Disconnected)), but stayed alive waiting for
some callbacks.
• I switched back to Online. A new connection was made; it claimed the
same bus name.
• Finally the callbacks fired, and thus the old connection was unreffed
and could be disposed. In _dispose(), TpBaseConnection drops its bus
name again.
This patch ensures that the name is released at most once, which should
fix this issue. I don't have a test case.
Fixes: <https://bugs.freedesktop.org/show_bug.cgi?id=32184>
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
|
| |
|
| |
|
|
|
|
| |
It no longer does anything.
|
| |
|
|
|
|
| |
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
|
|
|
|
|
|
|
|
| |
We're effectively using the bus name as a mutex to protect the object
path, because dbus-glib doesn't have failable object path acquisition.
Now that we (can) explicitly remove the object from the bus, we can do
that properly, fixing a longstanding bug.
|