| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
|
| |
|
|\ |
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
We still have multiple gtk-doc warnings which are much harder to fix,
such as things like this in the spec:
"see bug #26417"
html/telepathy-glib-channel-text.html:1538: warning: no link for: '26417:CAPS' -> (<span class="type">26417</span>).
and the change I made to the code generator in c0b13f7ccc26e78.
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Replace g_(ptr_)array_free (foo, TRUE) and g_hash_table_destroy
with respectively g_(ptr_)array_unref (foo) and g_hash_table_unref.
I used this command to generate this patch:
for f in `find -name "*.c"`; do sed -i $f -re 's/g_ptr_array_free \(([^ ,]+), TRUE\)/g_ptr_array_unref \(\1\)/'; done
See Danielle's blog for explanation of possible bug _free can do:
http://blogs.gnome.org/danni/2011/11/16/mistakes-with-g_value_set_boxed/
|
|/
|
|
| |
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
|
| |
|
| |
|
|
|
|
|
|
|
| |
Previously, the update_async vfunc in TpBaseRoomConfigClass took a
pointer to a TpBaseChannel as its first argument. This is an artifact of
how this was initially hooked up in Gabble, and is pretty
unconventional, to say the least.
|
|
|
|
|
|
|
|
|
|
|
| |
TpBaseRoomConfig stores a pointer to itself as qdata on its parent
channel. It did not previously NULL that pointer out when it was
disposed: it now does.
Correspondingly, I added an explicit check for NULL to find_myself().
While this is technically redundant with the TP_IS_BASE_ROOM_CONFIG()
check, I think it makes the error message clearer to distinguish between
the two.
|
|
|
|
|
|
|
|
|
|
| |
This is handier than using the GObject property, and it transpires that
subclasses would like to use it.
It returns a ref rather than not because TpBaseRoomConfig only holds a
weak ref to the channel, so it would otherwise be quite easy for CM code
to accidentally try to use a dead pointer. (I fell into this trap while
working on Gabble.)
|
|
This is a mixin-esque class (akin to TpBaseContactList) implementing the
RoomConfig interface on MUC channels.
This class was developed inside Gabble, and moved here when essentially
complete. Changes since the last time it appears in Gabble:
• Uses of wocky_enum_{to,from}_nick were replaced by
_tp_enum_{to,from}_nick;
• The description section of the documentation was written;
• Obviously, it was renamed.
|