summaryrefslogtreecommitdiff
path: root/src/idle-handles.c
Commit message (Collapse)AuthorAgeFilesLines
* Use TP_DISABLE_SINGLE_INCLUDEGuillaume Desmottes2013-09-161-2/+1
| | | | https://bugs.freedesktop.org/show_bug.cgi?id=69311
* Include config.h in each source fileSimon McVittie2013-04-241-0/+1
| | | | | | Among other effects, this makes GLIB_VERSION_MIN_REQUIRED effective. Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
* Various dull C89-complianceSimon McVittie2012-05-101-4/+10
| | | | | Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk> Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk>
* Use TP_ERROR, not deprecated TP_ERRORSSimon McVittie2012-05-081-2/+2
| | | | | | Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk> Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk> Bug: https://bugs.freedesktop.org/show_bug.cgi?id=49600
* Use idle_muc_channel_is_typecharDebarshi Ray2011-05-111-1/+2
|
* Add Protocol objectsSimon McVittie2010-11-181-1/+5
|
* Fix a buffer overrun in channel name validation.Will Thompson2010-04-061-1/+1
| | | | | | | | | I can't find any coherent specification for this type of channel name (which appear to start with ! and contain five upper-case or numeric chars). All the RFCs just reference other RFCs but it seems to be something to do with safe channels. Anyway... let's not blow up if someone actually tries to use one of these with less than five characters after the bang!
* Fix two valgrind-reported leaksJonathon Jongsma2009-10-071-6/+2
| | | | | | For some reason, we were strduping the channel name needlessly in _channel_normalize_func() Also, we forgot to free the bodies returned from idle_text_encode_and_split()
* Make nickname validation a for loop.Will Thompson2009-05-271-8/+2
| | | | I think this is clearer; it makes the loop's conditions more obvious.
* Don't spam DEBUG for each char in a nickWill Thompson2009-05-271-1/+0
|
* Be strict for what nicks we allow, and liberal for what nicks we accept from ↵Jonathon Jongsma2009-02-241-13/+39
| | | | | | | | | | | | | others Bip has a nasty habit of sending backlog activity from a fictional '-bip' user. Unfortunately, a nick with a leading '-' character is illegal according to the IRC RFCs, but we have to accept it since people appear to be using it in the wild. This patch adds a flag to the nick validation script that specifies whether we should use strict mode or lenient mode. We use strict mode for validating local nicknames, and lenient mode for validating remote nicknames.
* Merge branch 'invalid-nick'Jonathon Jongsma2009-02-171-11/+12
|\ | | | | | | | | Conflicts: tests/twisted/Makefile.am
| * Validate nicks per the IRC RFCJonathon Jongsma2009-01-301-9/+10
| | | | | | | | | | | | | | | | | | | | | | Previously we were allowing the nick to consist of any unicode alpha or digit characters, but the IRC spec (RFC2812 section 2.3.1) is very explicit about which characters are valid for a nick, and it's only ascii chars. In addition, we weren't disallowing '-' as the first character of a nickname as required by the IRC spec. Added a few additional tests for valid and invalid nicks
| * Expose the nick validation function and use it in the CMJonathon Jongsma2009-01-301-2/+2
| | | | | | | | | | | | | | Add a filter for the 'account' param of the RequestConnection method so that it can check if the passed nickname is valid for an IRC nick and reject it if not. Previously, telepathy-idle happily accepted invalid nicknames and then didn't provide any decent feedback about what was wrong when the 'login' failed.
* | Fix Bug #19766: private messages no longer delivered to group chatJonathon Jongsma2009-02-131-6/+0
|/ | | | | | | | | | | | | | | | This could perhaps be a slightly controversial change. The reason that the bug happened was that telepathy-idle's room handle repository normalizer function had some special code to make joining chatrooms more user-friendly. Basically, if the user specified a chatroom 'foo', it would assume you meant '#foo' and automatically prepend the '#' character. The way the parser currently works is that when we get in a privmsg, we try to parse the 'destination' of the privmsg as both a contact and a room. The way we determine if it's a valid room or not is by calling tp_handle_ensure(room_repo, ...) (and same for determining valid contacts). Unfortunately, because of the automatic #-prepending this means that a single privmsg destination can be both a valid contact and a valid channel name, so if the user is in a channel with the same name as their nick (but without the leading #), the privmsg will be handled by both the IMFactory and the MUCFactory
* Correct the order of "const static" to "static const"Will Thompson2008-08-291-1/+1
|
* Clean up includesOlli Salli2008-01-151-5/+3
| | | | 20080115205329-9db4d-6a57ff858a5ce98ae86074e81f3be814e05d6bd3.gz
* Unify coding style, chapter Six: Binary operators and their operands should ↵Olli Salli2007-12-271-2/+2
| | | | | | have whitespace in between 20071227220208-9db4d-2e018ea7b69ed08e7f17c909b2fa47470c4081e0.gz
* Unify coding style, lesson 4: blank lines after each case body in switch ↵Olli Salli2007-12-271-0/+2
| | | | | | statements 20071227203300-9db4d-47a1011afb9c3cd20b58f249b756744115b0b181.gz
* Remove tabs from places other than beginning of linesOlli Salli2007-12-271-1/+1
| | | | 20071227201813-9db4d-818203d16e295aa5bd678dd62cccffd76c836f17.gz
* Remove trailing whitespaceOlli Salli2007-12-271-2/+2
| | | | 20071227201423-9db4d-9747ce7d1faa02cd80ab78daeec4d2abad6af37f.gz
* Assume IRC channels with no prefix mean channels with prefix #Olli Salli2007-05-101-2/+12
| | | | 20070510101223-9db4d-a50c3ddec233076d28fd9bce763f4d1e5ee59281.gz
* Restyle idle-handles.[ch]Olli Salli2007-04-261-99/+47
| | | | 20070426095746-9db4d-ab40051022f1632a4fcf45d693e9954c92ea4471.gz
* Fix the license header copyright statements in all .c filesOlli Salli2007-04-101-2/+2
| | | | 20070410214915-9db4d-1fcb3dcb0f4873f0fba7ec08f32b32a110463dd3.gz
* Use TpBaseConnection in IdleConnection (with no MUC factory, we temporarily ↵Olli Salli2007-04-101-60/+0
| | | | | | lose MUC though) 20070410212647-9db4d-797a9f937dd925a75ffc5e7c1f4c73e703e599ea.gz
* Remove the TOTAL CRACKALL implementation of PresenceOlli Salli2007-04-051-29/+0
| | | | 20070405180531-9db4d-a38a8379863a578a13288c31cf62518761ab47d1.gz
* Add actual parsing to IdleParser, it now seems to parse stuff correctlyOlli Salli2007-03-311-6/+8
| | | | 20070331184618-9db4d-266d19b78932da09df53b3b21dc8b9d8ee328e7e.gz
* Only set original ID qdata if the id was validOlli Salli2007-03-291-3/+5
| | | | 20070329110457-9db4d-3b2383fb5f7978a015c2ef8f03ba212466d7dda1.gz
* Only set error in the normalization callbacks if error was providedOlli Salli2007-03-291-2/+4
| | | | 20070329100802-9db4d-14c99284f6798e076ac351561bc6eeccac09d951.gz
* Port to new handle repo APIOlli Salli2007-03-281-44/+55
| | | | 20070328152136-9db4d-4b0c241a38a6cab149f9af00bd5b243f39644048.gz
* Don't set idle_contact_presence_free for null ContactPresences - may prevent ↵Olli Salli2007-03-221-1/+1
| | | | | | a segfault 20070322172541-9db4d-8257aef413ac2393f9b8c034fd8d46af70efbbef.gz
* Migrate to the handle repos and sets in telepathy-glibOlli Salli2007-02-041-371/+54
| | | | 20070204223035-9db4d-eb01a394b0a783b0647d11c1a33d4dc8d15e1c7a.gz
* Migrate from G(IntSet,Heap) to the versions in telepathy-glibOlli Salli2007-01-311-10/+9
| | | | 20070131212013-9db4d-99121c1bfd2ddc080836012d11bfde0710ee811b.gz
* Initial import (migration from SF.net SVN)Olli Salli2007-01-291-0/+589
20070129154736-9db4d-be80727a61507e6581870228122d0d2a7c12995e.gz