| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
Spaces are not valid characters in property names, and never were.
Until recently GLib silently fixed up the name by replacing the
space with '-', but now tightened up the validation.
|
|\ |
|
| | |
|
| | |
|
| | |
|
| |
| |
| |
| |
| | |
See commit d70ba9ba46ea037b8003efc27de7f8c2d067befa in telepathy-glib.
See also: https://bugs.freedesktop.org/show_bug.cgi?id=46523
|
| | |
|
| |
| |
| |
| | |
maintainer-prepare-release: do "git tag" in srcdir
|
| |
| |
| |
| | |
Based on a commit by Slava Monich <slava.monich@jolla.com>
|
| |
| |
| |
| | |
https://bugs.freedesktop.org/show_bug.cgi?id=91272
|
| |
| |
| |
| | |
Based on a commit by Slava Monich <slava.monich@jolla.com>
|
| |
| |
| |
| | |
https://bugs.freedesktop.org/show_bug.cgi?id=91272
|
|\ \
| |/ |
|
| |
| |
| |
| |
| | |
Reviewed-by: George Kiagiadakis <gkiagia@tolabaki.gr>
https://github.com/TelepathyIM/telepathy-mission-control/pull/1
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| |
| | |
Otherwise, if we "goto error" too soon, we'll try to g_object_unref
uninitialized memory. gcc doesn't spot that because we're using
tp_clear_object, which uses an intermediate variable, and it doesn't
propagate "uninitializedness" through assignments.
|
| |
| |
| |
| | |
We were semi-consistently using it wrong.
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| | |
It seems that the order of the dbus signals is unpredictable,
so requiring it in the test sometimes makes it fail. It also
seems that the other checks above in the same unit test have
the same logic of not expecting a certain order in signal emission,
so this is probably the right thing to do.
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Apparently the nm library also tries to access the /.../Settings
object of NM, which was not available in our fake NM implementation.
This commit implements the basic properties of the Settings object,
which allows the tests to continue past this point.
https://bugs.freedesktop.org/show_bug.cgi?id=96917
|
| |
| |
| |
| |
| |
| | |
It is required to correctly show translated messages on some locales.
https://bugs.freedesktop.org/show_bug.cgi?id=93661
|
| |
| |
| |
| |
| |
| |
| | |
The code doesn't compile anymore, the features used have been removed.
The replacement is logind, for which support exists in MC since 5.15.1.
https://bugs.freedesktop.org/show_bug.cgi?id=70458
|
| |
| |
| |
| |
| |
| |
| | |
required for the fake-network-monitor in the unit tests
https://bugs.freedesktop.org/show_bug.cgi?id=96763
Reviewed-by: Diane Trout <diane@ghic.org>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
"connectivity" properties of GNetworkMonitor
"connectivity" is required since glib 2.44
"network-metered" is required since glib 2.46
https://bugs.freedesktop.org/show_bug.cgi?id=96763
Reviewed-by: Diane Trout <diane@ghic.org>
|
| |
| |
| |
| |
| | |
https://bugs.freedesktop.org/show_bug.cgi?id=94310
Reviewed-by: George Kiagiadakis
|
| |
| |
| |
| |
| |
| | |
nm support
This GError variable is not used anywhere else in this function.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This patch switches to use th enew libnm API, also snice nm_client_new
now takes a GError, I thought I'd report the error message if mission
control can't connect to the network manager.
Additionally we can remove a definition of the NM_CHECK_VERSION
macro for old versions of NM, as well as a guard for the
NM_STATE_DISCONNECTING constant.
|
| |
| |
| |
| |
| |
| |
| |
| | |
mcd_service_new() can return NULL if we didn't manage to connect to D-Bus.
Best to handle this gracefully rather than crashing horribly.
This is the top crasher on Ubuntu btw.
https://errors.ubuntu.com/problem/7e2a5f9a379f34a347895782ae948177926a1932
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| | |
The second argument has to be the type of the value.
https://bugs.freedesktop.org/show_bug.cgi?id=81751
|
| | |
|
| | |
|
| |
| |
| |
| |
| | |
Fix a regression introduced when backporting fix for
https://bugs.freedesktop.org/show_bug.cgi?id=79827
|
|\ \
| |/
| |
| |
| | |
Conflicts:
src/mcd-account.c
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The McdAccount object may still be alive for a short while because of pending
async operations. We want to get rid of the D-Bus object as soon as possible
and so, for example, a new Account object replacing the deleted one can be
created.
Fix https://bugs.freedesktop.org/show_bug.cgi?id=79827
|
| |
| |
| |
| |
| | |
It's more useful when reading logs than G_STRLOC and that's what we already
use in src/mcd-debug.h
|
| |
| |
| |
| | |
https://bugs.freedesktop.org/show_bug.cgi?id=79832
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Otherwise, holds_setup_lock is sometimes initially nonzero, making
us think we have the setup lock when really we don't, and leading
to an assertion failure when we try to release it.
For some reason I could only reproduce this during distcheck...
Reviewed-by: Xavier Claessens
(cherry picked from commit 6a073b02dbfda060142f7d47426fec55c7caba0d)
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
See:
https://wiki.gnome.org/action/show/Initiatives/GnomeGoals/InstalledTests
https://en.wikipedia.org/wiki/Test_Anything_Protocol
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=74626
Reviewed-by: Guillaume Desmottes
|
| | |
|
| |
| |
| |
| |
| | |
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=74581
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This lets us get rid of the "ready" vfunc on plugins: we now
connect to each plugin's signals only after we have called
mcp_account_storage_list(), so we won't get double-notification for
accounts that are both present in the initial list and signalled.
This means we can remove a queue of delayed signal emissions from the
test D-Bus plugin (and when it's ported to this API, from Empathy's
libaccounts/UOA plugin). As far as I can see, list() and ready() happen
within the same main-loop iteration anyway, so I don't think it was
even possible to receive notification of a new account in that window.
Empathy's GNOME Online Accounts plugin never really implemented this:
in theory, it was incorrect, since any account that happened to be
added between list() and ready() would be lost altogether. However,
list() and ready() seem to happen in the same main-loop iteration,
so this might never have been a practical concern.
Rather than "fixing" Empathy's GOA plugin, it seems better to remove
the difficult case altogether.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=74581
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
|
| |
| |
| |
| |
| |
| |
| |
| | |
Previously, we'd only wait for accounts added in mcd_storage_load()
to become ready.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=74581
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
|
| |
| |
| |
| |
| | |
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=74581
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
|
| |
| |
| |
| |
| |
| |
| |
| | |
If we're opportunistically migrating parameters according to
CM-specified types, we need to cope with uint16 ('q') for port numbers.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=71093
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
|
| |
| |
| |
| |
| |
| |
| | |
mcp_account_storage_get_parameter() doesn't raise a GError.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=71093
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
|
| | |
|
| |
| |
| |
| |
| |
| |
| | |
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=71093
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
[also depend on new tp-glib for
tp_connection_manager_param_dup_variant_type -smcv]
|