diff options
author | Xavier Claessens <xclaesse@gmail.com> | 2011-11-16 15:35:10 +0100 |
---|---|---|
committer | Xavier Claessens <xclaesse@gmail.com> | 2011-11-16 15:35:31 +0100 |
commit | b7cfa229c65ecba4d4a5e9e0ea90331e9d5bb269 (patch) | |
tree | 8ea475c882ba20c8b42bcc7348c361e8b55ceb54 /src/roomlist-channel.c | |
parent | 54f726c81670463a8bf16b4cd002d258f03aa05a (diff) | |
download | telepathy-salut-b7cfa229c65ecba4d4a5e9e0ea90331e9d5bb269.tar.gz |
Use _unref instead of _free _destroy when possible.unref
Replace g_(ptr_)array_free (foo, TRUE) and g_hash_table_destroy
with respectively g_(ptr_)array_unref (foo) and g_hash_table_unref.
I used this command to generate this patch:
for f in `find -name "*.c"`; do sed -i $f -re 's/g_ptr_array_free \(([^ ,]+), TRUE\)/g_ptr_array_unref \(\1\)/'; done
See Danielle's blog for explanation of possible bug _free can do:
http://blogs.gnome.org/danni/2011/11/16/mistakes-with-g_value_set_boxed/
Diffstat (limited to 'src/roomlist-channel.c')
-rw-r--r-- | src/roomlist-channel.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/roomlist-channel.c b/src/roomlist-channel.c index 362c37c9..66ca70d9 100644 --- a/src/roomlist-channel.c +++ b/src/roomlist-channel.c @@ -387,7 +387,7 @@ rooms_free (SalutRoomlistChannel *self) tp_handle_unref (room_repo, handle); } - g_ptr_array_free (priv->rooms, TRUE); + g_ptr_array_unref (priv->rooms); priv->rooms = NULL; } @@ -478,7 +478,7 @@ salut_roomlist_channel_add_room (SalutRoomlistChannel *self, 2, keys, G_MAXUINT); g_ptr_array_add (priv->rooms, g_value_get_boxed (&room)); - g_hash_table_destroy (keys); + g_hash_table_unref (keys); DEBUG ("add room %s", room_name); } |