diff options
| author | Yuxuan 'fishy' Wang <yuxuan.wang@reddit.com> | 2022-10-28 10:29:25 -0700 |
|---|---|---|
| committer | Yuxuan 'fishy' Wang <fishywang@gmail.com> | 2022-11-02 15:44:07 -0700 |
| commit | e8353cb46e9f5e71f9b76f55d6bf59530b7f98ef (patch) | |
| tree | 0a115e7b4edaf865c497a01196f9fc60acd8d734 /.github | |
| parent | 2acfe0fc7a1747c327da66c8a693840ba0c5a016 (diff) | |
| download | thrift-e8353cb46e9f5e71f9b76f55d6bf59530b7f98ef.tar.gz | |
Use multi-module to cleanup top level go.mod
Client: go
The go library itself does not have any third-party dependencies. We
have one third party dependency from the test code, which kind of
polluted from top-level go.mod file to the users of thrift go library.
We previous tried to clean that up by creating go.mod file at
lib/go/thrift, which caused issues to the release process and thus
reverted.
Use multi-module to separate tests requiring mock to their own modules
so that we can keep the top-level go.mod file clean.
Also some minor fixes on the github actions go workflow.
Diffstat (limited to '.github')
| -rw-r--r-- | .github/workflows/build.yml | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index b3ecd1eca..252ff2b55 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -78,7 +78,6 @@ jobs: run: | ./configure \ --disable-debug \ - --disable-tests \ --disable-dependency-tracking \ --without-cpp \ --without-c_glib \ @@ -118,9 +117,6 @@ jobs: - name: Run make check for lib/go run: make -C lib/go check - - name: Run make check for lib/go/test - run: make -C lib/go/test check - - name: Run make check for test/go run: make -C test/go check |