diff options
| author | Yuxuan 'fishy' Wang <yuxuan.wang@reddit.com> | 2020-06-27 08:34:31 -0700 |
|---|---|---|
| committer | Yuxuan 'fishy' Wang <fishywang@gmail.com> | 2020-06-30 10:07:48 -0700 |
| commit | 5dc1d268f5c63b804d0b185943467cfeb47859d5 (patch) | |
| tree | d57f0316bbfea7d7dfb9e86a3ec0f37c01fa7fe8 /CHANGES.md | |
| parent | 0dd1363931ac1f9a531b48ded7f1178194fa4ef6 (diff) | |
| download | thrift-5dc1d268f5c63b804d0b185943467cfeb47859d5.tar.gz | |
THRIFT-5152: Separate timeout in TSSLSocket
Client: go
We separated timeout in go's TSocket into connect timeout and socket
timeout in 81334cd, this change does the same for TSSLSocket to keep
them consistent.
Also rename the arg in NewTSocketFromConnTimeout from connTimeout to
socketTimeout, because in that function we already have a connection,
so connect timeout is never used again. The timeout passed into that
function is really for socket timeout, not connect timeout. The name of
that function actually means "New TSocket From Conn (with) Timeout", not
"New TSocket From ConnTimeout" (I guess that's where the original
confusion came from).
Also add the missing change note for the breaking change.
Diffstat (limited to 'CHANGES.md')
| -rw-r--r-- | CHANGES.md | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/CHANGES.md b/CHANGES.md index ceb8f8b6f..b6c202184 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -15,6 +15,7 @@ - [THRIFT-5164](https://issues.apache.org/jira/browse/THRIFT-5164) - In Go library TProcessor interface now includes ProcessorMap and AddToProcessorMap functions. - [THRIFT-5186](https://issues.apache.org/jira/browse/THRIFT-5186) - cpp: use all getaddrinfo() results when retrying failed bind() in T{Nonblocking,}ServerSocket - [THRIFT-5233](https://issues.apache.org/jira/browse/THRIFT-5233) - go: Now all Read*, Write* and Skip functions in TProtocol accept context arg +- [THRIFT-5152](https://issues.apache.org/jira/browse/THRIFT-5152) - go: TSocket and TSSLSocket now have separated connect timeout and socket timeout ### Java |