diff options
| author | Yuxuan 'fishy' Wang <yuxuan.wang@reddit.com> | 2021-08-26 11:04:27 -0700 |
|---|---|---|
| committer | Yuxuan 'fishy' Wang <yuxuan.wang@reddit.com> | 2021-08-27 09:28:37 -0700 |
| commit | 5f829f143c40a125c611d03244b235a6d1a35d47 (patch) | |
| tree | e3bc4f3783fa56dc321f1a11bf82bdffa74109c9 /CHANGES.md | |
| parent | 57b9aa0dd5ef2abd2825c9050783dafc75cc1698 (diff) | |
| download | thrift-5f829f143c40a125c611d03244b235a6d1a35d47.tar.gz | |
go: Fix things staticcheck complains about
Client: go
Staticcheck is the recommended replacement of the frozen and deprecated
official golint linter [1].
Fix the things it complained about (or add lint:ignore directive) in:
- lib/go/thrift
- lib/go/test/tests
- tutorial/go/src
- test/go/src
- compiler generated code
The majority of the fixes are in the following categories:
- Use of deprecated function (mainly the TConfiguration related ones)
- Redundant break in switch cases
- Unused and unexported variables/fields/functions
Also in the same spirit as fb539ae, remove the error return from
NewTSSLSocket as it can never be non-nil.
This change will be cherry-picked into 0.15.0 branch after merged.
[1]: https://groups.google.com/g/golang-nuts/c/rCP70Aq_tBc
Diffstat (limited to 'CHANGES.md')
| -rw-r--r-- | CHANGES.md | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/CHANGES.md b/CHANGES.md index bfd8cb090..2f45c0d46 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -15,7 +15,7 @@ - [THRIFT-5381](https://issues.apache.org/jira/browse/THRIFT-5381) - possible collisions at VOID type with some 3rd-party libraries on Haxe cpp targets - [THRIFT-5396](https://issues.apache.org/jira/browse/THRIFT-5396) - deprecate netstd "Async" method postfix -- [THRIFT-5453](https://issues.apache.org/jira/browse/THRIFT-5453) - go: NewTSocketConf no longer returns an error +- [THRIFT-5453](https://issues.apache.org/jira/browse/THRIFT-5453) - go: NewTSocketConf and NewTSSLSocketConf no longer return an error ### AS3 |